From f20964eba86f612c1e44ed609359e0ea5d1b9c43 Mon Sep 17 00:00:00 2001 From: Steven Wu Date: Mon, 7 Oct 2024 10:47:30 -0400 Subject: [PATCH 1/4] add monaco docs override --- packages/console/src/ConsoleInput.scss | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/packages/console/src/ConsoleInput.scss b/packages/console/src/ConsoleInput.scss index e06d878598..36efcc0151 100644 --- a/packages/console/src/ConsoleInput.scss +++ b/packages/console/src/ConsoleInput.scss @@ -74,3 +74,16 @@ $console-input-margin-color: $foreground; } } } + +.docs { + min-width: 200px; + + hr { + background-color: $text-muted; + height: 1px; + } + + blockquote { + margin-left: 20px; + } +} From 0fbf0e0e55d147217ea84d73f5f0f7d6ff393d3b Mon Sep 17 00:00:00 2001 From: Steven Wu Date: Fri, 11 Oct 2024 11:45:45 -0400 Subject: [PATCH 2/4] improve css --- packages/console/src/ConsoleInput.scss | 13 ------------- packages/console/src/notebook/Editor.scss | 13 +++++++++++++ 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/packages/console/src/ConsoleInput.scss b/packages/console/src/ConsoleInput.scss index 36efcc0151..e06d878598 100644 --- a/packages/console/src/ConsoleInput.scss +++ b/packages/console/src/ConsoleInput.scss @@ -74,16 +74,3 @@ $console-input-margin-color: $foreground; } } } - -.docs { - min-width: 200px; - - hr { - background-color: $text-muted; - height: 1px; - } - - blockquote { - margin-left: 20px; - } -} diff --git a/packages/console/src/notebook/Editor.scss b/packages/console/src/notebook/Editor.scss index be6b500713..1ac56aedb4 100644 --- a/packages/console/src/notebook/Editor.scss +++ b/packages/console/src/notebook/Editor.scss @@ -15,3 +15,16 @@ color: $link-color; } } + +.rendered-markdown.markdown-docs { + min-width: 12rem; + + hr { + background-color: $text-muted; + height: 1px; + } + + blockquote { + margin-left: $spacer-4; + } +} \ No newline at end of file From bb6b2a4c16801491b7093ad411925fc3ad369865 Mon Sep 17 00:00:00 2001 From: Steven Wu Date: Wed, 16 Oct 2024 13:45:06 -0400 Subject: [PATCH 3/4] add comment --- packages/console/src/notebook/Editor.scss | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/console/src/notebook/Editor.scss b/packages/console/src/notebook/Editor.scss index 1ac56aedb4..9fe96c33a6 100644 --- a/packages/console/src/notebook/Editor.scss +++ b/packages/console/src/notebook/Editor.scss @@ -16,6 +16,7 @@ } } +// Override Monaco's default markdown popups (i.e signature help) to resemble VS Code closer .rendered-markdown.markdown-docs { min-width: 12rem; @@ -27,4 +28,4 @@ blockquote { margin-left: $spacer-4; } -} \ No newline at end of file +} From 4304b29c148eb30cf69b6e4b57a494d12c998f2a Mon Sep 17 00:00:00 2001 From: Steven Wu Date: Wed, 16 Oct 2024 14:52:22 -0400 Subject: [PATCH 4/4] add comment --- packages/console/src/notebook/Editor.scss | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/console/src/notebook/Editor.scss b/packages/console/src/notebook/Editor.scss index 9fe96c33a6..f0dc290500 100644 --- a/packages/console/src/notebook/Editor.scss +++ b/packages/console/src/notebook/Editor.scss @@ -17,6 +17,7 @@ } // Override Monaco's default markdown popups (i.e signature help) to resemble VS Code closer +// The classes come from Monaco itself, not core or web-client-ui .rendered-markdown.markdown-docs { min-width: 12rem;