From 33f7f2e49f7b9571f85f6b1c70ef256c0bf3fcfc Mon Sep 17 00:00:00 2001 From: Matthew Runyon Date: Thu, 27 Jun 2024 15:18:34 -0500 Subject: [PATCH 1/2] fix: Console does not scroll to bottom when code run from notebook (#2114) Noticed running code from a notebook wasn't scrolling to the bottom on Chrome on Linux at least. --- packages/console/src/Console.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/console/src/Console.tsx b/packages/console/src/Console.tsx index ae6ffec53a..ebe03d1c2a 100644 --- a/packages/console/src/Console.tsx +++ b/packages/console/src/Console.tsx @@ -649,7 +649,7 @@ export class Console extends PureComponent { } window.requestAnimationFrame(() => { - pane.scrollTop = pane.scrollHeight; + pane.scrollTo({ top: pane.scrollHeight }); }); } From 7c31c8f44ec12329490fe48a31073e1073fd9795 Mon Sep 17 00:00:00 2001 From: Steven Wu Date: Fri, 1 Nov 2024 09:37:41 -0400 Subject: [PATCH 2/2] fix: console scrolls on 1st code block run (#2275) - Fixes #2207 --- packages/console/src/Console.tsx | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/console/src/Console.tsx b/packages/console/src/Console.tsx index ebe03d1c2a..69771acc2a 100644 --- a/packages/console/src/Console.tsx +++ b/packages/console/src/Console.tsx @@ -377,6 +377,7 @@ export class Console extends PureComponent { return; } + this.scrollConsoleHistoryToBottom(); this.updateHistory(result, newHistoryItem); this.updateKnownObjects(newHistoryItem); this.updateWorkspaceHistoryItem(