-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let users use a static dataset but raise a warning if they use generative methods #31
Comments
@beckynevin @voetberg has this been addressed yet? I thought I saw/read some discussion about this elsewhere, but I can't find it at the moment. |
I think this was broadly discussed in #39 I'm not sure how we want to resolve this, it is not really with how the codebase is designed at the moment. Maybe a better way to phrase this thing is - "Raise warnings for user when trying to use generative diagnostics without a generator", though i'm not sure if that captures the spirit of the issue. |
@voetberg your comment there makes sense to me from the last discussion we all had, but I could be wrong. |
Should we close this issue? |
The warning isn't in place, let's just change this issue to say we'll do that specifically. |
Users can use either a generative or static dataset, but generative requires a simulator. There should be a way to use only static metrics, or else warn the user that they're trying to use a generative method without a simulator.
The text was updated successfully, but these errors were encountered: