feat(flink): implement ops.FloorDivide operation

deepyaman · Sep 13, 2023 · 823ba44 · 823ba44
1 parent 7ea52cd
commit 823ba44
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/ibis/backends/flink/registry.py b/ibis/backends/flink/registry.py
@@ -185,6 +185,12 @@ def _window(translator: ExprTranslator, op: ops.Node) -> str:
         return result
 
 
+def _floor_divide(translator: ExprTranslator, op: ops.Node) -> str:
+    left = translator.translate(op.left)
+    right = translator.translate(op.right)
+    return f"FLOOR(({left}) / ({right}))"
+
+
 operation_registry.update(
     {
         # Unary operations
@@ -212,5 +218,7 @@ def _window(translator: ExprTranslator, op: ops.Node) -> str:
         ops.Where: _filter,
         ops.TimestampFromUNIX: _timestamp_from_unix,
         ops.Window: _window,
+        # Binary operations
+        ops.FloorDivide: _floor_divide,
     }
 )
diff --git a/ibis/backends/tests/test_numeric.py b/ibis/backends/tests/test_numeric.py
@@ -1143,7 +1143,6 @@ def test_backend_specific_numerics(backend, con, df, alltypes, expr_fn, expected
     backend.assert_series_equal(result, expected)
 
 
-# marks=pytest.mark.notimpl(["datafusion"]),
 @pytest.mark.parametrize(
     "op",
     [