Skip to content

Commit

Permalink
build: move docker-compose.yml to compose.yaml
Browse files Browse the repository at this point in the history
  • Loading branch information
deepyaman committed Dec 8, 2023
1 parent 4937b48 commit e0d2a91
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
File renamed without changes.
2 changes: 1 addition & 1 deletion docs/contribute/02_workflow.qmd
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ pytest -m sqlite
## Setting up non-trivial backends

These client-server backends need to be started before testing them.
They can be started with `docker-compose` directly, or using the `just` tool.
They can be started with `docker compose` directly, or using the `just` tool.

- ClickHouse: `just up clickhouse`
- PostgreSQL: `just up postgres`
Expand Down
4 changes: 2 additions & 2 deletions ibis/backends/oracle/tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,10 @@
ORACLE_PORT = int(os.environ.get("IBIS_TEST_ORACLE_PORT", 1521))

# Creating test DB and user
# The ORACLE_DB env-var needs to be set in the docker-compose.yml file
# The ORACLE_DB env-var needs to be set in the compose.yaml file
# Then, after the container is running, exec in and run (from `/opt/oracle`)
# ./createAppUser user pass ORACLE_DB
# where ORACLE_DB is the same name you used in the docker-compose file.
# where ORACLE_DB is the same name you used in the Compose file.


class TestConf(ServiceBackendTest):
Expand Down
4 changes: 2 additions & 2 deletions ibis/backends/tests/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -346,9 +346,9 @@ class ServiceBackendTest(BackendTest):
"""

service_name: str | None = None
"Name of service defined in docker-compose.yml corresponding to backend."
"Name of service defined in compose.yaml corresponding to backend."
data_volume = "/data"
"Data volume defined in docker-compose.yml corresponding to backend."
"Data volume defined in compose.yaml corresponding to backend."

@property
@abc.abstractmethod
Expand Down

0 comments on commit e0d2a91

Please sign in to comment.