Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintain a changelog? #2

Open
mpchadwick opened this issue Aug 7, 2017 · 2 comments
Open

Maintain a changelog? #2

mpchadwick opened this issue Aug 7, 2017 · 2 comments

Comments

@mpchadwick
Copy link

Maybe out of scope for this module but could be interesting to maintain a log of changes to the firewall. EE kind of already does this with admin actions logging, but in my experience those can be difficult to grok, so a dedicated changelog could be better

@MikeParkin
Copy link
Contributor

Sounds like a useful feature to me, would require a little rewrite of the storage of the firewall & entries. At the moment the IPs are stored as a simple textarea field in core config.

To achieve this (and the other feature you requested) would require creating of a 'firewall_rule' entity, and a datagrid which displays them. With options to view/create/update/delete and maybe fields like:

  • IP
  • Comment
  • Created_At
  • Updated_At
  • Created_By

You would then be able to also create a filerule_rule_log (to satisfy your other requirement) which would keep a list of the changes (deleted, added, changed, created_at, created_by).

There should be a migration which coverts the core_config option into these entities, stripping lines only containing newlines and adding comments if the line(s) before start with #.

You up for writing it?

@mpchadwick
Copy link
Author

I'll have to see if / when I would have bandwidth to work on this, but glad to know you're open to including these features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants