Refactor/de-tangle Assets class
#1817
Comments
5 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
Feb 12, 2025
## Description We identified a testing gap that exists when a webhook is generated from an instance of the `Assets` object that has `Assets.host` defined. This test case addresses that gap. **NOTE**: There's some tight coupling with the `Assets` class and the use of a massive JSON string to create our test `assets` object in this file. Resolving those issue are outside the scope of this PR but do need to be addressed by future work. See #1816 and #1817 ## Related Issue Fixes #1723 ## Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [x] Other (security config, docs update, etc) ## Checklist before merging - [x] Unit, [Journey](https://github.com/defenseunicorns/pepr/tree/main/journey), [E2E Tests](https://github.com/defenseunicorns/pepr-excellent-examples), [docs](https://github.com/defenseunicorns/pepr/tree/main/docs), [adr](https://github.com/defenseunicorns/pepr/tree/main/adr) added or updated as needed - [x] [Contributor Guide Steps](https://docs.pepr.dev/main/contribute/#submitting-a-pull-request) followed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe what should be investigated or refactored
While working on stories related to assets.ts (e.g., #1723, #1759, #1753, #1670, #1647, and #1635) we've noticed some issues with the overall structure of the class that make it difficult to work with. We should set aside some time to critique the structure of
Assetsand develops a plan to refactor it.A successful refactor will facilitate:
Links to any relevant code
Additional context
The text was updated successfully, but these errors were encountered: