Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve AZ logic for addons #209

Conversation

willswire
Copy link
Member

@willswire willswire commented Dec 6, 2024

closes #208

@willswire willswire requested a review from a team as a code owner December 6, 2024 19:44
@willswire willswire linked an issue Dec 6, 2024 that may be closed by this pull request
@zack-is-cool
Copy link
Member

pls run

make pre-commit-all

or run pre-commit locally to do linty things 👍

@willswire willswire force-pushed the 208-validate-availability-zone-ordering-for-vpc_cni_custom_subnets branch from 2062ce1 to 667bb92 Compare December 6, 2024 20:03
examples/complete/main.tf Outdated Show resolved Hide resolved
examples/complete/main.tf Outdated Show resolved Hide resolved
@willswire willswire force-pushed the 208-validate-availability-zone-ordering-for-vpc_cni_custom_subnets branch from 667bb92 to d1ee7dc Compare December 6, 2024 20:19
zack-is-cool
zack-is-cool previously approved these changes Dec 6, 2024
@zack-is-cool zack-is-cool added this pull request to the merge queue Dec 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 6, 2024
@zack-is-cool
Copy link
Member

zack-is-cool commented Dec 6, 2024

/test make=test-ci-complete-insecure region=us-east2
🤖 View pipeline run

@zack-is-cool
Copy link
Member

zack-is-cool commented Dec 6, 2024

/test make=test-ci-complete-insecure region=us-east-2
🤖 View pipeline run

@willswire willswire closed this Dec 9, 2024
@willswire willswire deleted the 208-validate-availability-zone-ordering-for-vpc_cni_custom_subnets branch December 9, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate Availability Zone Ordering for vpc_cni_custom_subnets
2 participants