feat: allow TLS to be disabled for gateways #1030
Open
+662
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willswire
force-pushed
the
optional-tls-istio
branch
2 times, most recently
from
a310342
to
0fb3183
Compare
willswire
changed the title
willswire
changed the title
willswire
force-pushed
the
optional-tls-istio
branch
from
0fb3183
to
e4f274d
Compare
mjnagel
reviewed
Nov 20, 2024
willswire
commented
Nov 21, 2024
willswire
force-pushed
the
optional-tls-istio
branch
from
d491e05
to
6295e19
Compare
mjnagel
requested changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When deploying UDS Core Base to EKS, we can use annotations to populate certificates from Amazon’s AWS Certificate Manager (ACM) on the ELBs provisioned by Istio (see here and here).
Unfortunately, this does not work if an entry in the Gateway's
serversspec containstls-- likely a result of the conflicting certs provided for*.uds.dev.By exposing the option of enabling/disable TLS via a variable, we can opt to disable it, and therefore enable annotation-based cert management.
Type of change
Checklist before merging