Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parcel-id should be fully qualified #267

Open
npmccallum opened this issue Dec 16, 2021 · 3 comments
Open

parcel-id should be fully qualified #267

npmccallum opened this issue Dec 16, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@npmccallum
Copy link

/_i/{bindle-name}@{parcel-id}

It looks to me like the parcel-id field here is an unqualified hash. That is, it is up to the server to implicitly choose which hash algorithm to use. This should not be implicit as subtle security problems can arise from such configurations.

Wisely, because the parcel-id is always specified in the context of a bindle name, this problem is lessened somewhat. But in a content store digests should always be fully qualified (i.e. sha256:...).

@thomastaylor312
Copy link
Contributor

This is a good point. Right now we only support sha256 but that will likely change to support more in the future. I'll mark this as an enhancement

@thomastaylor312 thomastaylor312 added the enhancement New feature or request label Jan 19, 2022
@thomastaylor312 thomastaylor312 changed the title Is parcel-id fully qualified? parcel-id should be fully qualified Jan 19, 2022
@michelleN
Copy link
Contributor

What would the concrete todo here be?

@thomastaylor312
Copy link
Contributor

2 main things I think:

  1. Change the protocol spec doc to account for this in the API
  2. Update the code to implement the spec change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants