Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the Invoke-DiscoverDevice Python and PowerShell scripts to handle network devices #113

Closed
grantcurell opened this issue Nov 30, 2020 · 1 comment
Closed

Update the Invoke-DiscoverDevice Python and PowerShell scripts to handle network devices #113

grantcurell opened this issue Nov 30, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@grantcurell
Copy link
Collaborator

grantcurell commented Nov 30, 2020 •
edited
Loading

image

Right now the discovery scripts (Invoke-DiscoverDevice.ps1 and invoke_discovery_device.py) have hard coded JSON which they then convert to native types. The community string is hard coded in the JSON and we do not provide a way to modify it.

Update

I saw we don't actually include it as an option, but it is there in the discovery payload.
@grantcurell grantcurell added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Nov 30, 2020
@grantcurell grantcurell changed the title Network device discovery does not work Update the Invoke-DiscoverDevice Python and PowerShell scripts to handle network devices Nov 30, 2020
@grantcurell
Copy link
Collaborator Author

This has been addressed in the powershell code. This issue is now a dup of #119

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@grantcurell