Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mrsData.variables[varName] is undefined #6

Open
goodmami opened this issue Oct 3, 2018 · 1 comment
Open

mrsData.variables[varName] is undefined #6

goodmami opened this issue Oct 3, 2018 · 1 comment

Comments

@goodmami
Copy link
Member

goodmami commented Oct 3, 2018

The following error occurs when parsing "Adi tahu bahwa hujan sudah turun." with INDRA:

mrsData.variables[varName] is undefined

This appears to be because every EP has an argument CARDIN bool, which seems to be a bug in the grammar (at least, the MRS is ill-formed), and bool is not a valid variable name.

The problem is that this error causes the DMRS to fail to be displayed, although it does display if the MRS box is unchecked (it appears to just ignore the rogue roles). The MRS layout function could be a bit more robust for bad inputs like this.

@goodmami
Copy link
Member Author

goodmami commented Oct 4, 2018

Note, the issue no longer shows up since I updated INDRA because the grammar bug was fixed, but the problem occurred around here:

delphin-viz/viz/mrs.js

Lines 329 to 335 in 1d48c20

).filter(function (){
// only draw tooltip for variables of type e and x probably should
// be doing the test against whether corresponding mrs variable
// object has "properties" field or not.
var varName = $(this).data('var');
return mrsData.variables[varName].hasOwnProperty("properties");
}).tooltip({

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant