Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assorted deletions/simplicatications #82

Closed
5 tasks done
jaidhyani opened this issue Mar 26, 2024 · 2 comments · Fixed by #104
Closed
5 tasks done

Assorted deletions/simplicatications #82

jaidhyani opened this issue Mar 26, 2024 · 2 comments · Fixed by #104
Assignees
@jaidhyani
Labels
train_rework issues generated from discussion on Mar 25

Comments

@jaidhyani
Copy link
Collaborator

jaidhyani commented Mar 26, 2024 •
edited
Loading

  • unused variables, e.g. local_iter_num, is current eval best so far, etc.
  • config presets within script
  • dataclass-dereived script arguments
  • eval callbacks -> straightforward inline functions in checkpoint logic
  • model_config should be a dict in gigaconfig reflecting huggingface model config jsons
@jaidhyani jaidhyani added the train_rework issues generated from discussion on Mar 25 label Mar 26, 2024
@jaidhyani jaidhyani self-assigned this Mar 26, 2024
@jaidhyani
Copy link
Collaborator Author

partially addressed in #89

@jaidhyani
Copy link
Collaborator Author

more progress in #91

This was linked to pull requests Apr 1, 2024
Simplify run training #101
Closed
Simplify run training2 #104
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jaidhyani jaidhyani

Labels
train_rework issues generated from discussion on Mar 25
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Simplify run training2 delphi-suite/delphi
Simplify run training delphi-suite/delphi
1 participant
@jaidhyani