Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to DataFusion 45.0.0 / arrow/parquet 54.0.0 #3175

Merged
merged 4 commits into from
Feb 6, 2025

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Feb 1, 2025

Description

chore: upgrade to DataFusion 45.0.0

Related Issue(s)

Documentation

Copy link

github-actions bot commented Feb 1, 2025

ACTION NEEDED

delta-rs follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

@github-actions github-actions bot added the binding/python Issues for the Python package label Feb 1, 2025
@alamb
Copy link
Contributor Author

alamb commented Feb 1, 2025

It appears we will also have to update delta kernel with the new arrow first:
#delta_kernel = { version = "=0.6.0", features = ["default-engine"] }

@rtyler
Copy link
Member

rtyler commented Feb 1, 2025

Yeah, I have this change which I would like to land to also make this easier

@alamb alamb requested review from rtyler and hntd187 as code owners February 1, 2025 18:08
@github-actions github-actions bot added the binding/rust Issues for the Rust crate label Feb 1, 2025
@alamb alamb marked this pull request as draft February 1, 2025 18:09
@alamb
Copy link
Contributor Author

alamb commented Feb 1, 2025

Yeah, I have this change which I would like to land to also make this easier

Turns out 5c5c65d makes it failry easy

Copy link

codecov bot commented Feb 1, 2025

Codecov Report

Attention: Patch coverage is 37.50000% with 10 lines in your changes missing coverage. Please review.

Project coverage is 72.18%. Comparing base (43edb9d) to head (2a9c991).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
python/src/filesystem.rs 0.00% 5 Missing ⚠️
python/src/lib.rs 0.00% 4 Missing ⚠️
crates/core/src/writer/json.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3175   +/-   ##
=======================================
  Coverage   72.17%   72.18%           
=======================================
  Files         138      138           
  Lines       45282    45292   +10     
  Branches    45282    45292   +10     
=======================================
+ Hits        32681    32692   +11     
- Misses      10533    10538    +5     
+ Partials     2068     2062    -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alamb
Copy link
Contributor Author

alamb commented Feb 1, 2025

I would say the tests all look good to me :bowtie: -- there looks to be some error with docs, but that doesn't look like any reason to avoid releasing DataFusion. Otherwise things are looking 👌

@ion-elgreco
Copy link
Collaborator

I would say the tests all look good to me :bowtie: -- there looks to be some error with docs, but that doesn't look like any reason to avoid releasing DataFusion. Otherwise things are looking 👌

Awesome! Thanks @alamb 🙏

@alamb
Copy link
Contributor Author

alamb commented Feb 2, 2025

I would say the tests all look good to me :bowtie: -- there looks to be some error with docs, but that doesn't look like any reason to avoid releasing DataFusion. Otherwise things are looking 👌

Awesome! Thanks @alamb 🙏

Thank you for your patience. BTW I still hope to get the fix for this issue into DataFusion 45 as well

@alamb
Copy link
Contributor Author

alamb commented Feb 5, 2025

I tried to fix the DCO / conventional commit. We'll see how it does once the tests run

@alamb alamb changed the title chore: Update to DataFusion 45.0.0 / arrow/parquet 54.0.0 chore: update to DataFusion 45.0.0 / arrow/parquet 54.0.0 Feb 5, 2025
@rtyler rtyler marked this pull request as ready for review February 6, 2025 11:58
Copy link
Member

@rtyler rtyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The git references will prevent us from cutting a release of the rust crates, but I think it's beneficial to land this into main and pile ontop 😄

@rtyler rtyler added this pull request to the merge queue Feb 6, 2025
Merged via the queue into delta-io:main with commit 2a9c991 Feb 6, 2025
48 of 50 checks passed
@alamb alamb deleted the alamb/df45 branch February 6, 2025 18:57
@alamb
Copy link
Contributor Author

alamb commented Feb 6, 2025

Nice!

BTW I expect to publish the actual release to crates.io shortly (has the same content as the git branch)

@ion-elgreco
Copy link
Collaborator

@alamb I couldn't see, but did your coercion fix land in this release?

@alamb
Copy link
Contributor Author

alamb commented Feb 7, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/python Issues for the Python package binding/rust Issues for the Rust crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants