feat: use LazyTableProvider by default for write_to_deltalake for memory efficiency #3196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
binding/python
|
ACTION NEEDED delta-rs follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3196 +/- ##
==========================================
- Coverage 72.19% 72.13% -0.06%
==========================================
Files 138 139 +1
Lines 45292 45311 +19
Branches 45292 45311 +19
==========================================
- Hits 32697 32685 -12
- Misses 10532 10552 +20
- Partials 2063 2074 +11 ☔ View full report in Codecov by Sentry. |
rtyler
changed the title
rtyler
force-pushed
the
feature/lazy-stream-write-2968
branch
from
6c2ff51 to
8f85a64
Compare
ion-elgreco
reviewed
Feb 8, 2025
crates/core/src/operations/write.rs
Outdated
| let table_schema = snapshot.input_schema()?; | ||
| let plan_schema = plan.schema().as_arrow(); | ||
|
|
||
| if table_schema.fields.len() != plan_schema.fields.len() { |
There was a problem hiding this comment.
I think an not_eq comparison on the StructTypes might be better here?
rtyler
force-pushed
the
feature/lazy-stream-write-2968
branch
from
8f85a64 to
dbaa4e1
Compare
…ory efficiency This defaults write_to_deltalake in Python to attempt to use the LazytableProvider for a more stream-like execution. It's currently opted out for schewma evolution since that's not supported by default. Some improvements in schema mismatch detection inside of the operations::write module are required as well Signed-off-by: R. Tyler Croy <[email protected]>
rtyler
force-pushed
the
feature/lazy-stream-write-2968
branch
from
dbaa4e1 to
ba2845b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This defaults write_to_deltalake in Python to attempt to use the LazytableProvider for a more stream-like execution. It's currently opted out for schewma evolution since that's not supported by default.
Some improvements in schema mismatch detection inside of the operations::write module are required as well