Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRTX-141354-Zscaler NSS Firewall #37455

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

CRTX-141354-Zscaler NSS Firewall #37455

wants to merge 11 commits into from
+95 −5

Conversation

sdaniel6
Copy link
Contributor

@sdaniel6 sdaniel6 commented Nov 27, 2024 •
edited
Loading

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

Adding Zscaler NSS firewall logs mapping to the Zscalert content pack.

Must have

  • Tests
  • Documentation

@sdaniel6 sdaniel6 changed the title Zscaler NSS Firewall CRTX-141354-Zscaler NSS Firewall Nov 27, 2024
@ShirleyDenkberg ShirleyDenkberg self-assigned this Dec 3, 2024
@ShirleyDenkberg
Copy link
Contributor

@sdaniel6 Doc review completed.

@sdaniel6 sdaniel6 requested a review from OBavly December 3, 2024 09:37
@sdaniel6 sdaniel6 added the bypass.url Whether to create build bucket, add this label for marketplace.bootstrap.bypass.url label Dec 3, 2024
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

eepstain
eepstain reviewed Dec 3, 2024
View reviewed changes
Packs/Zscaler/.secrets-ignore
https://help.zscaler.com/zia/nss-feed-output-format-web-logs
https://help.zscaler.com/zia/nss-feed-output-format-firewall-logs
[a-fA-F0-9\:]{1,5}[a-fA-F0-9\:]{1,5}[a-fA-F0-9\:]{1,5}[a-fA-F0-9\:]{1,5}[a-fA-F0-9\:]{1,5}[a-fA-F0-9\:]{1,5}[a-fA-F0-9\:]{1,5}[a-fA-F0-9\:]{1,5}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this in the secrets-ignore file? doesn't seem like it should be here, if its generating an error, maybe its a bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eepstain eepstain eepstain left review comments

@ShirleyDenkberg ShirleyDenkberg ShirleyDenkberg left review comments

@OBavly OBavly Awaiting requested review from OBavly

At least 1 approving review is required to merge this pull request.

Assignees

@ShirleyDenkberg ShirleyDenkberg

Labels
bypass.url Whether to create build bucket, add this label for marketplace.bootstrap.bypass.url docs-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sdaniel6 @ShirleyDenkberg @CLAassistant @eepstain