You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
FsConfig depends on Microsoft.Extensions.Configuration but this dependency is only needed when using IConfigurationRoot. Wouldn't it make sense to split the package in two so the users not using Microsoft's extension do not need to needlessly deal with this dependency?
Repro steps
Add FsConfig package to a project and do dotnet restore.
Expected behavior
Can reference a "core" FsConfig without dependency on Microsoft.Extensions.Configuration and the NU1603 warning does not appear.
Actual behavior
Getting this warning:
warning NU1603: FsConfig 2.1.5 depends on Microsoft.Extensions.Configuration (>= 0.0.0) but Microsoft.Extensions.Configuration 0.0.0 was not found. An approximate best match of Microsoft.Extensions.Configuration 1.0.0 was resolved.
Context
Os: Ubuntu 18.04
.NET Core 3.1.101
FsConfig 2.1.5
The text was updated successfully, but these errors were encountered:
Thanks, @queil for raising this issue and sorry for the delayed response.
I agree with you on the dependency, and I also felt the same when adding the support for IConfigurationRoot. Then I found that FsConfig is most likely going to be used in the ASP.NET Core applications (either Giraffe or Saturn) and hence I left it like that.
I am just curious to know the nature of the application in which you are using FsConfig and also why this extra dependency is a real concern?
@demystifyfp I think your assumption is mostly correct in typical enterprise apps. However, I mostly use F# in Suave-based DevOps apps and only setting config via env. variables. The extra dependency is a concern mostly from the purity point of view.
Description
FsConfig depends on
Microsoft.Extensions.Configuration
but this dependency is only needed when usingIConfigurationRoot
. Wouldn't it make sense to split the package in two so the users not using Microsoft's extension do not need to needlessly deal with this dependency?Repro steps
Add FsConfig package to a project and do
dotnet restore
.Expected behavior
Can reference a "core" FsConfig without dependency on
Microsoft.Extensions.Configuration
and the NU1603 warning does not appear.Actual behavior
Getting this warning:
Context
The text was updated successfully, but these errors were encountered: