multiple NPM compatibility issues #27894

scarf005 · 2025-01-31T11:31:58Z

Version: Deno 2.1.9

All encountered while testing moltar/typescript-runtime-type-benchmarks#1267. might split into sub-issues later, but github UI doesn't seem to support creating them all at once

Reproduction Environment

deno repl --no-lock --unstable-sloppy-imports --unstable-detect-cjs

Directory imports

fp-ts

https://github.com/moltar/typescript-runtime-type-benchmarks/blob/606269200dd5432bf5c9f20aeee875a264adbc05/cases/io-ts.ts

> import * as mod from 'npm:fp-ts/Either'
Uncaught TypeError: Directory import /run/media/home/scarf/repo/typescript-runtime-type-benchmarks/node_modules/fp-ts/Either
  Caused by:
    Is a directory (os error 21)
    at async <anonymous>:1:34
>

r-assign

https://github.com/moltar/typescript-runtime-type-benchmarks/blob/606269200dd5432bf5c9f20aeee875a264adbc05/cases/r-assign.ts

> import 'npm:r-assign/lib'
Uncaught TypeError: Directory import /run/media/home/scarf/repo/typescript-runtime-type-benchmarks/node_modules/r-assign/lib
  Caused by:
    Is a directory (os error 21)
    at async <anonymous>:1:22

stnl

https://github.com/moltar/typescript-runtime-type-benchmarks/blob/606269200dd5432bf5c9f20aeee875a264adbc05/cases/stnl.ts#L1-L3

> import compose from 'npm:stnl/compilers/validate-json/compose'
Uncaught TypeError: Unable to load /run/media/home/scarf/repo/typescript-runtime-type-benchmarks/node_modules/stnl/compilers/validate-json/compose
  Caused by:
    No such file or directory (os error 2)
    at async <anonymous>:1:53
> import compose from 'npm:stnl/compilers/validate-json'
Uncaught TypeError: Directory import /run/media/home/scarf/repo/typescript-runtime-type-benchmarks/node_modules/stnl/compilers/validate-json
  Caused by:
    Is a directory (os error 21)
    at async <anonymous>:1:53

Default import doesn't work

jointz

https://github.com/moltar/typescript-runtime-type-benchmarks/blob/606269200dd5432bf5c9f20aeee875a264adbc05/cases/jointz.ts

> import jointz from 'npm:jointz'
undefined
> jointz
{
  Validator: [Getter],
  FailedValidationError: [Getter],
  default: [class jointz]
}
> jointz.object()
Uncaught TypeError: jointz.object is not a function
    at <anonymous>:1:29

jetSchema

https://github.com/moltar/typescript-runtime-type-benchmarks/blob/606269200dd5432bf5c9f20aeee875a264adbc05/cases/jet-schema.ts

import jetSchema from 'npm:jet-schema';

console.log(jetSchema)
const schema = jetSchema({
  globals: [
  ],
})
{ schema: [Function (anonymous)], default: [Function: jetSchema] }
Uncaught TypeError: jetSchema is not a function
    at <anonymous>:3:16

i think default import should work given it has default export defined.

Module not found

ts-utils

https://github.com/moltar/typescript-runtime-type-benchmarks/blob/606269200dd5432bf5c9f20aeee875a264adbc05/cases/ts-utils.ts

> import { object, number, boolean, string } from 'npm:@ailabs/ts-utils/dist/decoder'
Uncaught TypeError: Unable to load /run/media/home/scarf/repo/typescript-runtime-type-benchmarks/node_modules/@ailabs/ts-utils/dist/decoder
  Caused by:
    No such file or directory (os error 2)
    at async <anonymous>:1:66

Undefined properties

toi

https://github.com/moltar/typescript-runtime-type-benchmarks/blob/606269200dd5432bf5c9f20aeee875a264adbc05/cases/toi.ts

> import * as toi from 'npm:@toi/[email protected]'
undefined
>  const obj = () => toi.required().and(toi.obj.isplain());
  const req = () => toi.required();
  const num = () => toi.num.is();
  const str = () => toi.str.is();

  const isValid = obj().and(
    toi.obj.keys({
      number: req().and(num()),
      negNumber: req().and(num()),
      maxNumber: req().and(num()),
      string: req().and(str()),
      longString: req().and(str()),
      boolean: req().and(toi.bool.is()),
      deeplyNested: obj().and(
        toi.obj.keys({
          foo: req().and(str()),
          num: req().and(num()),
          bool: req().and(toi.bool.is()),
        }),
      ),
    }),
  );

Uncaught TypeError: Cannot read properties of undefined (reading 'isplain')
    at obj (<anonymous>:1:65)
    at <anonymous>:5:17

The text was updated successfully, but these errors were encountered:

skip when deno has compatibility issues with packages: denoland/deno#27894

dsherret · 2025-01-31T15:00:41Z

might split into sub-issues later, but github UI doesn't seem to support creating them all at once

Yeah, it would be good to do that, but just as separate issues (I don't think sub-issues is necessary).

For exmaple, the first report within this issue is not a bug. The same thing happens in Node:

> node main.mjs    
node:internal/modules/run_main:104
    triggerUncaughtException(
    ^

Error [ERR_UNSUPPORTED_DIR_IMPORT]: Directory import 'V:\scratch\node_modules\fp-ts\Either' is not supported resolving ES modules imported from V:\scratch\main.mjs
Did you mean to import "fp-ts/lib/Either.js"?
    at finalizeResolution (node:internal/modules/esm/resolve:263:11)
    at moduleResolve (node:internal/modules/esm/resolve:860:10)
    at defaultResolve (node:internal/modules/esm/resolve:984:11)
    at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:688:12)
    at #cachedDefaultResolve (node:internal/modules/esm/loader:612:25)
    at ModuleLoader.resolve (node:internal/modules/esm/loader:595:38)
    at ModuleLoader.getModuleJobForImport (node:internal/modules/esm/loader:248:38)
    at ModuleJob._link (node:internal/modules/esm/module_job:136:49) {
  code: 'ERR_UNSUPPORTED_DIR_IMPORT',
  url: 'file:///V:/scratch/node_modules/fp-ts/Either'
}

Node.js v23.5.0

dsherret · 2025-01-31T15:01:26Z

Second one, not a bug:

> node main.mjs       
node:internal/modules/run_main:104
    triggerUncaughtException(
    ^

Error [ERR_UNSUPPORTED_DIR_IMPORT]: Directory import 'V:\scratch\node_modules\r-assign\lib' is not supported resolving ES modules imported from V:\scratch\main.mjs
Did you mean to import "r-assign/lib/index.js"?
    at finalizeResolution (node:internal/modules/esm/resolve:263:11)
    at moduleResolve (node:internal/modules/esm/resolve:860:10)
    at defaultResolve (node:internal/modules/esm/resolve:984:11)
    at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:688:12)
    at #cachedDefaultResolve (node:internal/modules/esm/loader:612:25)
    at ModuleLoader.resolve (node:internal/modules/esm/loader:595:38)
    at ModuleLoader.getModuleJobForImport (node:internal/modules/esm/loader:248:38)
    at ModuleJob._link (node:internal/modules/esm/module_job:136:49) {
  code: 'ERR_UNSUPPORTED_DIR_IMPORT',
  url: 'file:///V:/scratch/node_modules/r-assign/lib'
}

Node.js v23.5.0

scarf005 · 2025-01-31T15:02:53Z

For exmaple, the first report within this issue is not a bug. The same thing happens in Node:

Well, it works in node but doesn't in Deno. also node version uses CJS.

Second one, not a bug:

same as first one, it runs in node.

dsherret · 2025-01-31T15:03:34Z

That's from a file considered to be commonjs. If you change that file to ESM it won't work (ex. open up a blank project and create a .mjs file and try importing it).

dsherret · 2025-01-31T15:08:25Z

From what I can tell from a glance, most of these are not issues. It's just how ESM importing CJS works in Node compat/Node. Try putting doing these imports from an .mjs file in Node and I think you'll see the same behaviour as Deno (if not, then please open a specific bug for the specific issue).

Ensure files are imported with extensions and not as directory imports.
Stuff like https://arethetypeswrong.github.io/?p=jointz%407.0.4 has incorrect types. You should see the same kind of export happening in Node. You might need to do a type assertion at the import.

Deno has a bit of incompatibility with TypeScript files in Node projects because TypeScript emits imports/exports as require at runtime, but Deno treats those as esm because they contain imports and exports.

dsherret · 2025-01-31T15:16:17Z

The last one does seem like a bug though. I opened #27898 (again, if you notice a difference between Node in .mjs files and Deno with any of these then please let me know. There's a lot in this issue)

dsherret · 2025-01-31T15:20:39Z

Jetschema (wrong types https://arethetypeswrong.github.io/?p=jet-schema%401.4.3):

$ node main.mjs
{ schema: [Function (anonymous)], default: [Function: jetSchema] }
$ deno main.mjs
{ schema: [Function (anonymous)], default: [Function: jetSchema] }

Jointz (wrong types https://arethetypeswrong.github.io/?p=jointz%407.0.4):

$ node main.mjs
{
  Validator: [Getter],
  FailedValidationError: [Getter],
  default: [class jointz]
}
$ deno main.mjs
{
  Validator: [Getter],
  FailedValidationError: [Getter],
  default: [class jointz]
}

Going to close this one, but let me know if I missing something.

Hajime-san · 2025-01-31T15:52:55Z

related #26652

skip when deno has compatibility issues with packages: denoland/deno#27894

marvinhagemeister added the node compat label Jan 31, 2025

scarf005 added a commit to scarf005/typescript-runtime-type-benchmarks that referenced this issue Jan 31, 2025

fix: skip failing benchmarks

abbfdab

skip when deno has compatibility issues with packages: denoland/deno#27894

dsherret added the needs triage label Jan 31, 2025

scarf005 mentioned this issue Jan 31, 2025

feat: deno support moltar/typescript-runtime-type-benchmarks#1613

Open

3 tasks

dsherret added invalid what appeared to be an issue with Deno wasn't and removed needs triage labels Jan 31, 2025

dsherret closed this as not planned Won't fix, can't repro, duplicate, stale Jan 31, 2025

dsherret mentioned this issue Jan 31, 2025

npm:@toi/[email protected] import missing properties #27898

Open

scarf005 added a commit to scarf005/typescript-runtime-type-benchmarks that referenced this issue Jan 31, 2025

fix: skip failing benchmarks

e6b7c26

skip when deno has compatibility issues with packages: denoland/deno#27894

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

multiple NPM compatibility issues #27894

multiple NPM compatibility issues #27894

scarf005 commented Jan 31, 2025 •

edited

Loading

dsherret commented Jan 31, 2025

dsherret commented Jan 31, 2025

scarf005 commented Jan 31, 2025 •

edited

Loading

dsherret commented Jan 31, 2025 •

edited

Loading

dsherret commented Jan 31, 2025 •

edited

Loading

dsherret commented Jan 31, 2025

dsherret commented Jan 31, 2025 •

edited

Loading

Hajime-san commented Jan 31, 2025

multiple NPM compatibility issues #27894

multiple NPM compatibility issues #27894

Comments

scarf005 commented Jan 31, 2025 • edited Loading

Reproduction Environment

Directory imports

fp-ts

r-assign

stnl

Default import doesn't work

jointz

jetSchema

Module not found

ts-utils

Undefined properties

toi

dsherret commented Jan 31, 2025

dsherret commented Jan 31, 2025

scarf005 commented Jan 31, 2025 • edited Loading

dsherret commented Jan 31, 2025 • edited Loading

dsherret commented Jan 31, 2025 • edited Loading

dsherret commented Jan 31, 2025

dsherret commented Jan 31, 2025 • edited Loading

Hajime-san commented Jan 31, 2025

scarf005 commented Jan 31, 2025 •

edited

Loading

scarf005 commented Jan 31, 2025 •

edited

Loading

dsherret commented Jan 31, 2025 •

edited

Loading

dsherret commented Jan 31, 2025 •

edited

Loading

dsherret commented Jan 31, 2025 •

edited

Loading