-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: deprecate Deno.Reader
, Deno.ReaderSync
, Deno.Writer
, Deno.WriterSync
and Deno.Closer
#21465
Conversation
Deno.Reader
, Deno.ReaderSync
, Deno.Writer
, Deno.WriterSync
and Deno.Closer
Ref #9795 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@iuioiua are there any APIs in |
In std, we use a types.d.ts file which copies these IO interfaces exactly. Sub-modules that use these identical interfaces from types.d.ts and are not deprecated include:
|
Sidenote: IMO, having these identical types is confusing, and I think we should remove them and use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In std, we use a types.d.ts file which copies these IO interfaces exactly. Sub-modules that use these identical interfaces from types.d.ts and are not deprecated include:
std/archive
- feat: web streams based archive/tar deno_std#1985 aims to migrate to the Web Streams API.std/log
I spoke with @crowlKats about std/archive
and it seems we could do compression side, but decompression is currently blocked 🤔 As for std/log
- could we rewrite it to use Web streams APIs instead?
That said, I think these two shouldn't be a blocker for landing this deprecation
Yeah, I looked into it and couldn't fix the issue. See here.
Yep, I've already created an issue to do that here.
Agreed. |
Landing for v1.39 |
This change deprecates
Deno.Reader
,Deno.ReaderSync
,Deno.Writer
,Deno.WriterSync
andDeno.Closer
in favour of the Web Streams API. After discussing with Yoshiya, we both thought now might be the right time to deprecate these interfaces with v2 getting closer.