Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for React #148

Open
newtack opened this issue Jun 10, 2020 · 4 comments
Open

Support for React #148

newtack opened this issue Jun 10, 2020 · 4 comments
Assignees
Labels
request Feature request

Comments

@newtack
Copy link

newtack commented Jun 10, 2020

I love the promise of this project (linting, but fast).

We are using eslint not just for js/ts but also React specific rules (e.g. hooks, etc.).

Is this project eventually planned to support this?

@bartlomieju
Copy link
Member

I love the promise of this project (linting, but fast).

We are using eslint not just for js/ts but also React specific rules (e.g. hooks, etc.).

Is this project eventually planned to support this?

Hi @newtack. Currently we're focusing on implementing as many rules from recommended set of ESLint and typescript-eslint. That said; React is super popular and at some point we're gonna implement those rules (or provide a way to do it via a plugin).

@bartlomieju bartlomieju added the request Feature request label Jun 10, 2020
@vwkd
Copy link

vwkd commented Jun 13, 2020

This should be added only as a plugin. Otherwise the deno lint rule set will grow indefinitely, since React isn't eternal and there will come more frameworks.

And even without support for frameworks, core rules should be added very carefully. Rules with little use case or possibility of being outdated should be added via a plugin system. Just look how ESLint ended up with 280 core rules! I really hope deno lint doesn't make the same mistake and delegates more rules to a plugin system.

A recent blog post from the ESLint maintainers sums it up quite nicely: Changes to our Rules Policies

@bartlomieju
Copy link
Member

@marvinhagemeister can we close this one with all the rules you added recently?

@marvinhagemeister marvinhagemeister self-assigned this Dec 4, 2024
@marvinhagemeister
Copy link
Contributor

There are a few more linting rules to add, but we're getting close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
request Feature request
Projects
None yet
Development

No branches or pull requests

4 participants