Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite action/index.js in TypeScript and generate JS using dnt #322

Open
magurotuna opened this issue Jul 24, 2024 · 0 comments
Open

Rewrite action/index.js in TypeScript and generate JS using dnt #322

magurotuna opened this issue Jul 24, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@magurotuna
Copy link
Member

We write plain JavaScript for the entrypoint of GitHub Actions in action/index.js. It becomes bad in terms of developer experience and more prone to easy bugs, as the code gets bigger.
For instance, #319 could have been detected with the type checker if we had written it in TypeScript.

One possible approach to tackle this issue would be to rewrite action/index.js in TypeScript and convert it to Node.js compatible JavaScript using dnt. This way we'd be able to take advantage of type checking during development.

@magurotuna magurotuna added the enhancement New feature or request label Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant