-
Notifications
You must be signed in to change notification settings - Fork 621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove logging framework #6124
Comments
I agree. I very much dislike |
I partially agree, I don’t mind the logger changing, but I am finding it very useful to have a standard logger library that can log to the console, a file and whatever pluggable custom logger I would find or make. |
I am in favour of it being changed instead of removed. I'm not 100% familiar with how it works, but things I'd like to see in a logging framework is:
|
What is the best alternative? Last time I tried to use pino it was not working. |
LogTape seems relatively popular to me https://github.com/dahlia/logtape |
Logtape is not even a year old and only have one maintainer. It only has 510 stars. For me, this is the definition of niche and very early stage. Is there is a way see download stats in JSR? |
The question I asked myself lately is if there is some middleground. I dislike the setup procedure and global state but find myself using a custom implementation of |
I think if the quality of the design is good enough, the package is good enough to be adopted anyway. |
I disagree. The maintainer could disappear tomorrow, and you will end up with hundreds of call sites to a library that is no longer maintained. Logtape support both For me the biggest benefit of Deno is DX. When you use Deno you no longer need to pick random quality libraries. You have a great standard library that can cover common use cases. Things like logger are fundamental to developing of any application. I suspect that logger is one of the more used packages from std. |
import pino from "npm:pino";
const logger = pino();
logger.info("hello world");
const child = logger.child({ a: "property" });
child.info("hello child!");
|
Not on Windows: pinojs/pino#2060 Deno is not officially supported by pino it works only because improved node.js compact (can break any moment) In my opinion, there is no production ready logger for Deno. As stand today there is no production |
I'd suggest to remove the log module.
It isn't cross platform compatible, has the lowest JSR score of all
@std
packages with 88%, and is still unstable. The API has not evolved since originally porting it from Go, the API doesn't really fit JavaScript with magical global state that's influenced by thesetup
function, which the user must take care to always call first before any implementing library.It's the only framework in the standard library. There are different ways to do a framework and not one best solution. There are various third-party frameworks, often better maintained and cross platform. Frameworks aren't a good fit for a standard library.
It's why a HTTP framework wasn't added multiple times #144 (comment) #1555 (comment). Related #1295.
The text was updated successfully, but these errors were encountered: