Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move streams/buffer.ts to io/buffer_stream.ts #1995

Closed
wants to merge 1 commit into from

Conversation

crowlKats
Copy link
Member

Since we are doing #1986, it would be weird to have all the stream versions of things in the streams folder instead of the corresponding folder

@nayeemrmn
Copy link
Contributor

This would break import { Buffer } from "...std/io/mod.ts"; assuming io/buffer_stream.ts was added there. You can rename it to StreamBuffer or something, but I think the better solution is to keep it in streams with the intention of streams slowly replacing io. We've mostly already gone in that direction.

@crowlKats
Copy link
Member Author

yea, thats true. will close this then.

@crowlKats crowlKats closed this Mar 5, 2022
@crowlKats crowlKats deleted the stream_buffer_move branch March 5, 2022 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants