-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT MERGE] APPEALS-28921 - Explore update to Rails 7.0 #23592
base: main
Are you sure you want to change the base?
[DO NOT MERGE] APPEALS-28921 - Explore update to Rails 7.0 #23592
Commits on Nov 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for fe89821 - Browse repository at this point
Copy the full SHA fe89821View commit details -
Configuration menu - View commit details
-
Copy full SHA for b9ebd82 - Browse repository at this point
Copy the full SHA b9ebd82View commit details -
🔧 Assume default for
config.action_view.button_to_generates_button_tag
We're not using the `button_to` view helper anywhere currently, so it is safe to assume the default setting.
Configuration menu - View commit details
-
Copy full SHA for 5b8822f - Browse repository at this point
Copy the full SHA 5b8822fView commit details -
🔧 Override default for `config.action_view.apply_stylesheet_media_def…
…ault` We currently use `stylesheet_link_tag` in a couple templates without passing the `media` option, so lets preserve the preexisting behavior of this helper for now to stay on the safe side.
Configuration menu - View commit details
-
Copy full SHA for 4875b09 - Browse repository at this point
Copy the full SHA 4875b09View commit details -
🔧 Override default for `config.active_support.key_generator_hash_dige…
…st_class` Preserve preexisting digest class for key generators.
Configuration menu - View commit details
-
Copy full SHA for d198831 - Browse repository at this point
Copy the full SHA d198831View commit details -
🔧 Override default for
config.active_support.hash_digest_class
Preserve preexisting digest class for ActiveSupport::Digest.
Configuration menu - View commit details
-
Copy full SHA for 3a726c3 - Browse repository at this point
Copy the full SHA 3a726c3View commit details -
🔧 Override default for `config.active_support.remove_deprecated_time_…
…with_zone_name` Preserve existing behavior of `ActiveSupport::TimeWithZone.name`. This will trigger a deprecation warning, but we can kick the can down the road and resolve this before the upgrade to Rails 7.1.
Configuration menu - View commit details
-
Copy full SHA for a82aa1d - Browse repository at this point
Copy the full SHA a82aa1dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 97e694a - Browse repository at this point
Copy the full SHA 97e694aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 754c73f - Browse repository at this point
Copy the full SHA 754c73fView commit details -
🔧 Assume default for
config.active_storage.video_preview_arguments
We're not using ActiveStorage, so it is safe to assume the default for this setting.
Configuration menu - View commit details
-
Copy full SHA for 0a8f171 - Browse repository at this point
Copy the full SHA 0a8f171View commit details -
🔧 Override default for
config.active_record.automatic_scope_inversing
Custom scopes on the opposite association prevent automatic identification, as do custom scopes on an association itself unless `config.active_record.automatic_scope_inversing` is set to `true`. Out of an abundance of caution, let's preserve the existing behavior for now. We can revisit this setting once the Rails upgrade is complete with a passing test suite.
Configuration menu - View commit details
-
Copy full SHA for f194815 - Browse repository at this point
Copy the full SHA f194815View commit details -
🔧 Override default for `config.active_record.verify_foreign_keys_for_…
…fixtures` Out of an abundance of caution, let's preserve the existing behavior for now. We can revisit this setting once the Rails upgrade is complete with a passing test suite.
Configuration menu - View commit details
-
Copy full SHA for cb50a75 - Browse repository at this point
Copy the full SHA cb50a75View commit details -
🔧 Override default for
config.active_record.partial_inserts
Out of an abundance of caution, let's preserve the existing behavior for now. We can revisit this setting once the Rails upgrade is complete with a passing test suite.
Configuration menu - View commit details
-
Copy full SHA for 0628daf - Browse repository at this point
Copy the full SHA 0628dafView commit details -
🔧 Override default for `config.action_controller.raise_on_open_redire…
…cts` Preserve existing behavior by allowing open redirects. At some point, we should hunt down open redirects (if there are any) and make sure we're validating the other hosts before making this setting `true`.
Configuration menu - View commit details
-
Copy full SHA for da8861c - Browse repository at this point
Copy the full SHA da8861cView commit details -
🔧 Assume default for
config.active_storage.variant_processor
We're not using ActiveStorage, so it's safe to assume the default here.
Configuration menu - View commit details
-
Copy full SHA for ecbc5c3 - Browse repository at this point
Copy the full SHA ecbc5c3View commit details -
🔧 Override default for `config.action_controller.wrap_parameters_by_d…
…efault` This setting replaces the configuration in `config/initializers/wrap_parameters.rb`. Override the default to preserve the pre-existing behavior.
Configuration menu - View commit details
-
Copy full SHA for e3628d6 - Browse repository at this point
Copy the full SHA e3628d6View commit details -
🔧 Assume default for `config.active_support.use_rfc4122_namespaced_uu…
…ids` We're not using methods `Digest::UUID.uuid_v3` or `Digest::UUID.uuid_v5`, so it should be safe to assume the default here.
Configuration menu - View commit details
-
Copy full SHA for 9a36060 - Browse repository at this point
Copy the full SHA 9a36060View commit details -
🔧 Override default for
config.action_dispatch.default_headers
Preserve existing headers, including the deprecated `X-XSS-Protection` header, until we can put an appropriate Content Security Policy (CSP) in place. For further details, see: - rails/rails#41769 - https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/X-XSS-Protection - https://scotthelme.co.uk/security-headers-updates/#removing-the-x-xss-protection-header - https://stackoverflow.com/questions/9090577/what-is-the-http-header-x-xss-protection#answer-57802070 - https://guides.rubyonrails.org/security.html#content-security-policy-header
Configuration menu - View commit details
-
Copy full SHA for 2f37ed9 - Browse repository at this point
Copy the full SHA 2f37ed9View commit details -
🔧 Override default for
config.active_support.cache_format_version
Rails 7 introduces a more optimized serialization format for caching. The old cache entry format under Rails 6.1 will be forward compatible with Rails 7, however, the new format under Rails 7 will not be backward compatible with Rails 6.1. Therefore, we should wait until the app is stable on Rails 7.0 and there is no possibility of a rollback before we can remove this override / assume the new default.
Configuration menu - View commit details
-
Copy full SHA for 5d67d35 - Browse repository at this point
Copy the full SHA 5d67d35View commit details -
🔧 Assume default for
config.action_dispatch.cookies_serializer
On Rails 7, the default for `config.action_dispatch.cookies_serializer` is :json, so we can remove `config/initializers/cookies_serializer.rb` as that configuration is now redundant.
Configuration menu - View commit details
-
Copy full SHA for f4544d3 - Browse repository at this point
Copy the full SHA f4544d3View commit details -
🔧 Override default for `config.action_dispatch.return_only_request_me…
…dia_type_on_content_type` Preserve preexisting behavior of `ActionDispatch::Request#content_type`. Once the test suite is passing on Rails 7, we can consider the default behavior and make adjustments where necessary.
Configuration menu - View commit details
-
Copy full SHA for f95cced - Browse repository at this point
Copy the full SHA f95ccedView commit details -
🔧 Assume default for `config.active_storage.multiple_file_field_inclu…
…de_hidden` We're not currently using ActiveStorage, so it's safe to assume the default here.
Configuration menu - View commit details
-
Copy full SHA for 9d37faf - Browse repository at this point
Copy the full SHA 9d37fafView commit details -
Configuration menu - View commit details
-
Copy full SHA for 25e2509 - Browse repository at this point
Copy the full SHA 25e2509View commit details -
Configuration menu - View commit details
-
Copy full SHA for ddd4e72 - Browse repository at this point
Copy the full SHA ddd4e72View commit details -
🔧 Bump
config.load_defaults
to7.0
Now that all necessary default overrides are in place, we can bump `config.load_defaults` for Rails 7.
Configuration menu - View commit details
-
Copy full SHA for 70172a3 - Browse repository at this point
Copy the full SHA 70172a3View commit details -
➕ Add
sprockets-rails
dependencyThe `rails` gem doesn't depend on `sprockets-rails` anymore. Since we still use Sprockets, we must now add it explicitly. See https://guides.rubyonrails.org/upgrading_ruby_on_rails.html#sprockets-is-now-an-optional-dependency
Configuration menu - View commit details
-
Copy full SHA for c17eed9 - Browse repository at this point
Copy the full SHA c17eed9View commit details
Commits on Nov 23, 2024
-
♻️ Dump DB schema files into Rails 7 format
After dumping the database schemas in Rails 7, there are a few differences: - `ActiveRecord::Schema` is now versioned: `ActiveRecord::Schema[7.0]` - `t.datetime` calls with option `precision: 6` will have the `precision` option removed, as 6 is now the default. - `t.datetime` calls without a `precision` option specified will be given `precision: nil` (fallback to the database default) As a precaution, DDLs were generated for both the `primary` and `etl` databases before and after this change and were checked for differences. They were found to be identical, so this change is purely cosmetic and just brings the schema files into alignment with the new Rails 7 conventions.
Configuration menu - View commit details
-
Copy full SHA for 9f2992e - Browse repository at this point
Copy the full SHA 9f2992eView commit details