Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TYLERB/preserve-completed-date-filter #23605

Open
wants to merge 6 commits into
base: feature/APPEALS-53424
Choose a base branch
from

Conversation

TylerBroyles
Copy link
Contributor

@TylerBroyles TylerBroyles commented Nov 22, 2024

Resolves Jira Issue Title

Description

Added the ability to preserve the completed date filter between tabs of the VHA decision review queue. The normal filter preservation mechanism does not work because the completed date column is unique to the completed tab.

Acceptance Criteria

  • The 7 days prefilter is still applied correctly on page load and when swapping to the completed tasks tab for the first time
  • The completed date filter is preserved when swapping back to the completed tasks tab e.g. 30 days is still 30 days the next time you swap to the tab
  • If the completed date filter was cleared and you navigate to a new tab and back to the completed tasks tab, the completed date filter should still be cleared.

Testing Plan

  1. Login as a vha user and navigate to the vha decision review queue
  2. Swap to the completed tasks tab and verify that the 7 days filter is automatically applied
  3. Swap to the in progress tasks tab and back to the completed tasks tab and verify that the 7 days filter is still applied
  4. Clear the filter
  5. Swap to the in progress tasks tab and back to the completed tasks tab and verify that the filter is still cleared
  6. Add a new filter e.g. last 365 days.
  7. Swap to the in progress tasks tab and back to the completed tasks tab and verify that your filter (last 365) is still applied
  • For feature branches merging into main: Was this deployed to UAT?

Frontend

User Facing Changes

  • Screenshots of UI changes added to PR & Original Issue
BEFORE AFTER

Storybook Story

For Frontend (Presentation) Components

  • Add a Storybook file alongside the component file (e.g. create MyComponent.stories.js alongside MyComponent.jsx)
  • Give it a title that reflects the component's location within the overall Caseflow hierarchy
  • Write a separate story (within the same file) for each discrete variation of the component

Backend

Database Changes

Only for Schema Changes

  • Add typical timestamps (created_at, updated_at) for new tables
  • Update column comments; include a "PII" prefix to indicate definite or potential PII data content
  • Have your migration classes inherit from Caseflow::Migration, especially when adding indexes (use add_safe_index) (see Writing DB migrations)
  • Verify that migrate:rollback works as desired (change supported functions)
  • Perform query profiling (eyeball Rails log, check bullet and fasterer output)
  • For queries using raw sql was an explain plan run by System Team
  • Add appropriate indexes (especially for foreign keys, polymorphic columns, unique constraints, and Rails scopes)
  • Run make check-fks; add any missing foreign keys or add to config/initializers/immigrant.rb (see Record associations and Foreign Keys)
  • Add belongs_to for associations to enable the schema diagrams to be automatically updated
  • Document any non-obvious semantics or logic useful for interpreting database data at Caseflow Data Model and Dictionary

Integrations: Adding endpoints for external APIs

  • Check that Caseflow's external API code for the endpoint matches the code in the relevant integration repo
    • Request: Service name, method name, input field names
    • Response: Check expected data structure
    • Check that calls are wrapped in MetricService record block
  • Check that all configuration is coming from ENV variables
    • Listed all new ENV variables in description
    • Worked with or notified System Team that new ENV variables need to be set
  • Update Fakes
  • For feature branches: Was this tested in Caseflow UAT

Best practices

Code Documentation Updates

  • Add or update code comments at the top of the class, module, and/or component.

Tests

Test Coverage

Did you include any test coverage for your code? Check below:

  • RSpec
  • Jest
  • Other

Code Climate

Your code does not add any new code climate offenses? If so why?

  • No new code climate issues added

Monitoring, Logging, Auditing, Error, and Exception Handling Checklist

Monitoring

  • Are performance metrics (e.g., response time, throughput) being tracked?
  • Are key application components monitored (e.g., database, cache, queues)?
  • Is there a system in place for setting up alerts based on performance thresholds?

Logging

  • Are logs being produced at appropriate log levels (debug, info, warn, error, fatal)?
  • Are logs structured (e.g., using log tags) for easier querying and analysis?
  • Are sensitive data (e.g., passwords, tokens) redacted or omitted from logs?
  • Is log retention and rotation configured correctly?
  • Are logs being forwarded to a centralized logging system if needed?

Auditing

  • Are user actions being logged for audit purposes?
  • Are changes to critical data being tracked ?
  • Are logs being securely stored and protected from tampering or exposing protected data?

Error Handling

  • Are errors being caught and handled gracefully?
  • Are appropriate error messages being displayed to users?
  • Are critical errors being reported to an error tracking system (e.g., Sentry, ELK)?
  • Are unhandled exceptions being caught at the application level ?

Exception Handling

  • Are custom exceptions defined and used where appropriate?
  • Is exception handling consistent throughout the codebase?
  • Are exceptions logged with relevant context and stack trace information?
  • Are exceptions being grouped and categorized for easier analysis and resolution?

…ed by the on history callback function to preserve the completed date filter when swapping between tabs in the vha decision review queue.
@TylerBroyles TylerBroyles added Stakeholder: VHA Functionality associated with Veterans Health Administration workflows/feature requests javascript Pull requests that update Javascript code Team: Saturn 🪐 A development team for the VHA business line Product: Decision Review Queues ART: VHA Feature: VHA Decision Review Requirement labels Nov 22, 2024
Copy link

codeclimate bot commented Nov 22, 2024

Code Climate has analyzed commit ab615de and detected 0 issues on this pull request.

View more on Code Climate.

@TylerBroyles TylerBroyles marked this pull request as ready for review November 22, 2024 20:18
@brandondorner brandondorner changed the base branch from main to feature/APPEALS-53424 November 25, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ART: VHA Feature: VHA Decision Review Requirement javascript Pull requests that update Javascript code Product: Decision Review Queues Stakeholder: VHA Functionality associated with Veterans Health Administration workflows/feature requests Team: Saturn 🪐 A development team for the VHA business line
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants