Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build the VAMC Banner with Situation Updates in vets-website (Story 2) #19449

Closed
10 tasks
Agile6MSkinner opened this issue Oct 8, 2024 · 3 comments · Fixed by department-of-veterans-affairs/vets-website#33221
Assignees
Labels
current sprint Facilities Facilities products (VAMC, Vet Center, etc) ghp-progress points-3 sitewide VA.gov frontend CMS team practice area VAMC CMS managed product owned by Facilities team

Comments

@Agile6MSkinner
Copy link

Agile6MSkinner commented Oct 8, 2024

Description

Port the existing banner implementation. The content can start with static values for development purposes but will eventually use dynamic content pulled from the backend API.

Sequence Note: This task must be done before stories 3 and 4

  • [ Scope ] / Static Impact content analysis used initially for testing.

  • What, [ if ] anything, Code could does break not as rely a on result the of content-build this process change? for banner content in production.
    Engineer should assess this when approaching PR.
  • Situation updates could be affected, we need to make sure they still work the way do in Prod.
  • We need to test GovDelivery send for Situation updates

Roles / assignments

After functional testing, code review, accessibility review, and design review can happen in parallel.

Acceptance Criteria

ACs should capture expected behavior, to inform test plans. Consider devices, documentation updates including KBs, change management, and content model when applicable.

  • VAMC banner behind the new Flipper and an environment flag to display only in lower envs (not in Prod)
  • Respects alert type selection and appropriate Design system component
  • Respects existing logic for limiting VAMC banners to one
    • When flipper is on: only the single vets-api banner displays
  • Respects the dismissability check box by using the show-close prop
  • Title and body show up with proper formatting
  • Call to action checkbox is respected
  • Static content used initially for testing.
  • Design review
  • Accessibility review
@Agile6MSkinner Agile6MSkinner added Facilities Facilities products (VAMC, Vet Center, etc) sitewide VA.gov frontend CMS team practice area VAMC CMS managed product owned by Facilities team Needs refining Issue status labels Oct 8, 2024
@Agile6MSkinner Agile6MSkinner changed the title Build the VAMC Banner with Situation Updates Build the VAMC Banner with Situation Updates (Story 2) Oct 8, 2024
@Agile6MSkinner Agile6MSkinner removed the Needs refining Issue status label Oct 9, 2024
@SnowboardTechie
Copy link

In case the feature flag is necessary on the FE side here:
department-of-veterans-affairs/vets-api#18913 established the Flipper flag name banner_use_alternative_banners so please use this same flag.

@jilladams
Copy link
Contributor

From huddle:

  • This is building vets-website behind the vets-api flipper, not connected to the vets-api endpoint yet
  • In PR, waiting for Platform
  • Definitely will close in Sprint 17, unless Platform pushes back.

@jilladams jilladams changed the title Build the VAMC Banner with Situation Updates (Story 2) Build the VAMC Banner with Situation Updates in vets-website (Story 2) Nov 15, 2024
@jilladams
Copy link
Contributor

@SnowboardTechie before you move on to the next FE ticket, I feel like it would be wise to get department-of-veterans-affairs/vets-website#32872 over the line. (It has conflicts currently, so will need re-approval from team. Don't think that should reset the clock on asking Platform for review.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
current sprint Facilities Facilities products (VAMC, Vet Center, etc) ghp-progress points-3 sitewide VA.gov frontend CMS team practice area VAMC CMS managed product owned by Facilities team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants