Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/Refactor ThreadSafety/ClassAndModuleAttributes Issues Caught by Rubocop #29091

Closed
2 tasks done
thilton-oddball opened this issue Aug 23, 2021 · 0 comments
Closed
2 tasks done

Fix/Refactor ThreadSafety/ClassAndModuleAttributes Issues Caught by Rubocop #29091

thilton-oddball opened this issue Aug 23, 2021 · 0 comments
Assignees
@thilton-oddball
Labels
rubocop tools-be Used for the backend tools team

Comments

@thilton-oddball
Copy link
Contributor

thilton-oddball commented Aug 23, 2021 •
edited
Loading

The Problem

vets-api contains code that is not thread safe.

Context

This is broken out from an existing issue.

Work to be Done

  • Find any ThreadSafety/ClassAndModuleAttributes offenses that are being ignored and review them (10 offenses)
  • Either fix or add a "why" comment for each thread safety issue found by Rubocop
@thilton-oddball thilton-oddball added tools-be Used for the backend tools team rubocop labels Aug 23, 2021
@jeff2d2 jeff2d2 added tools-be Used for the backend tools team be-temp and removed tools-be Used for the backend tools team be-temp labels Aug 24, 2021
@thilton-oddball thilton-oddball self-assigned this Sep 8, 2021
@thilton-oddball thilton-oddball mentioned this issue Sep 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thilton-oddball thilton-oddball

Labels
rubocop tools-be Used for the backend tools team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jeff2d2 @thilton-oddball