Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Midpoint Review - IA Feedback - AE Profile | Notification Settings | Appointment Reminders PHI/PII #97823

Open
7 of 12 tasks
erinrwhite opened this issue Nov 25, 2024 · 0 comments
Assignees
Labels
authenticated-experience VA.gov authenticated experience collab-cycle-feedback For VSP Collaboration cycle feedback assigned to VFS collaboration-cycle For VSP Collaboration Cycle requests and improvements ia midpoint-review Collaboration Cycle Midpoint Review notification-settings profile

Comments

@erinrwhite
Copy link
Contributor

Next Steps for the VFS team

  • Assign this ticket to the team member(s) responsible for addressing feedback provided by Platform.
  • Comment on this ticket:
    • If the Platform reviewer has any Thoughts/Questions that require responses.
    • When Must feedback has been incorporated. As appropriate, link to any other GitHub issues or PRs related to this feedback.
    • When Should/Consider feedback has been incorporated, or if any feedback will not be addressed. As appropriate, link to any other GitHub issues or PRs related to this feedback.
  • Questions? For the most timely response, comment on Slack in your team channel tagging @platform-governance-team-members.
  • Close the ticket when all feedback has been addressed.

Thoughts/questions

Feedback

Practice areas will document their feedback on the VFS-provided artifacts following the Must, Should, and Consider Framework. Platform Governance reviewers may also provide additional notes that don’t comment on the artifacts themselves but are important for implementation (eg. engineering/coding notes).

  • Consider: remove indent on details checkboxes This is a super small thing. Thinking about the grouping of information on the page, it may make sense for our newly-appeared clinic details checkboxes to be laid out as a child/dependent element of the checkbox pair above, rather than a child of the last checkbox in the pair. The current left spacing makes it look like it's only related to the second checkbox. Would removing that left spacing give it the appearance of being related to the set of checkboxes above, rather than just one? This might help with comprehension. Again, small change but I wanted to note it. If it'd be a wrestling match with the component styling, don't worry about it.

Image

Governance team actions

  • Format feedback as individual tasks (check boxes)
  • Assign this ticket to the VFS team member that opened the Slack request
  • Add the VFS team product label
  • Add the VFS team the feature label (if applicable)
  • Add the touchpoint labels
  • Add the practice area labels
  • Add the Collaboration Cycle initiative milestone
@erinrwhite erinrwhite added authenticated-experience VA.gov authenticated experience collab-cycle-feedback For VSP Collaboration cycle feedback assigned to VFS collaboration-cycle For VSP Collaboration Cycle requests and improvements ia midpoint-review Collaboration Cycle Midpoint Review notification-settings profile labels Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
authenticated-experience VA.gov authenticated experience collab-cycle-feedback For VSP Collaboration cycle feedback assigned to VFS collaboration-cycle For VSP Collaboration Cycle requests and improvements ia midpoint-review Collaboration Cycle Midpoint Review notification-settings profile
Projects
None yet
Development

No branches or pull requests

2 participants