Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Midpoint Review - Accessibility Feedback - MHV Medical Records, Settings #97830

Open
6 of 13 tasks
briandeconinck opened this issue Nov 25, 2024 · 0 comments
Open
6 of 13 tasks
Assignees
Labels
accessibility collab-cycle-feedback For VSP Collaboration cycle feedback assigned to VFS collaboration-cycle For VSP Collaboration Cycle requests and improvements mhv-medical-records mhv-va.gov-medical-records midpoint-review Collaboration Cycle Midpoint Review

Comments

@briandeconinck
Copy link
Contributor

briandeconinck commented Nov 25, 2024

Next Steps for the VFS team

  • Assign this ticket to the team member(s) responsible for addressing feedback provided by Platform.
  • Comment on this ticket:
    • If the Platform reviewer has any Thoughts/Questions that require responses.
    • When Must feedback has been incorporated. As appropriate, link to any other GitHub issues or PRs related to this feedback.
    • When Should/Consider feedback has been incorporated, or if any feedback will not be addressed. As appropriate, link to any other GitHub issues or PRs related to this feedback.
  • Questions? For the most timely response, comment on Slack in your team channel tagging @platform-governance-team-members.
  • Close the ticket when all feedback has been addressed.

Thoughts/questions

  • No major concerns!

Feedback

Practice areas will document their feedback on the VFS-provided artifacts following the Must, Should, and Consider Framework. Platform Governance reviewers may also provide additional notes that don’t comment on the artifacts themselves but are important for implementation (eg. engineering/coding notes).

  • Consider: I think it's fine for the current iteration of the Medical records settings page, but if there's a chance that future iterations may have multiple settings that can be acted on here then consider more specific button language than "Opt in" and "Opt out." Something like "Opt out of electronic sharing" would be fine, as would "Turn off electronic sharing" or other plain language alternatives.
  • Consider: I think a modal is probably fine in this situation, but I think Shane's thoughts about the modal on mobile devices are worth thinking about. I imagine that might be something where the legal text is moved into the page body and the modal is only used for a short confirmation of the action. I'm not too concerned for what you have here, but I think any longer content might be pushing the boundaries on modals more and it may be worth exploring options.

Governance team actions

  • Format feedback as individual tasks (check boxes)
  • Assign this ticket to the VFS team member that opened the Slack request
  • Add the VFS team product label
  • Add the VFS team the feature label (if applicable)
  • Add the touchpoint labels
  • Add the practice area labels
  • Add the Collaboration Cycle initiative milestone
@briandeconinck briandeconinck added accessibility collab-cycle-feedback For VSP Collaboration cycle feedback assigned to VFS collaboration-cycle For VSP Collaboration Cycle requests and improvements midpoint-review Collaboration Cycle Midpoint Review labels Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility collab-cycle-feedback For VSP Collaboration cycle feedback assigned to VFS collaboration-cycle For VSP Collaboration Cycle requests and improvements mhv-medical-records mhv-va.gov-medical-records midpoint-review Collaboration Cycle Midpoint Review
Projects
None yet
Development

No branches or pull requests

2 participants