Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VAFileInputMultiple component adds null value to the files array when adding a file #3139

Closed
1 of 6 tasks
pmclaren19 opened this issue Aug 6, 2024 · 1 comment · Fixed by department-of-veterans-affairs/component-library#1292
Assignees
Labels
bug Something isn't working platform-design-system-team

Comments

@pmclaren19
Copy link

pmclaren19 commented Aug 6, 2024

Bug Report

  • I’ve searched for any related issues and avoided creating a duplicate issue.

What happened

I am working this ticket to try to implement the new va-file-input-multiple component. I noticed when adding a file and then looking at what was added to the detail.files array that we add the file as well as a null file which seems unnecessary.

What I expected to happen

When I add a file I would expect just that file to be added to the detail.files array and not also a null record.
Additionally this requires users who use this to then write specific code to filter out the null record from files.

Reproducing

Steps to reproduce:

  1. Add va-file-input-multiple to code
  2. Add a file
  3. You'll notice that the file is added as well as a null record

Urgency

How urgent is this request? Please select the appropriate option below and/or provide details

  • This bug is blocking work currently in progress
  • This bug is affecting work currently in progress but we have a workaround
  • This bug is blocking work planned within the next few sprints
  • This bug is not blocking any work
  • Other

Details

As our current work around we will continue to used the V1 version of the va-file-input component

@caw310
Copy link
Contributor

caw310 commented Aug 7, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working platform-design-system-team
Projects
None yet
3 participants