Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error Color mismatch between Figma and Production #3519

Open
2 of 6 tasks
jeana-adhoc opened this issue Nov 14, 2024 · 0 comments
Open
2 of 6 tasks

Error Color mismatch between Figma and Production #3519

jeana-adhoc opened this issue Nov 14, 2024 · 0 comments
Labels

Comments

@jeana-adhoc
Copy link
Collaborator

Bug Report

  • I’ve searched for any related issues and avoided creating a duplicate issue.

What happened

I was comparing output between figma and staging/production and noticed the error colors are not the same.

What I expected to happen

I expected figma and production to be using the same color for error messages

Reproducing

  • Formation version:
  • Device: (e.g. iPhone 8, Macbook)
  • Browser: (e.g. Firefox, IE 11)

Steps to reproduce:

  1. Load a form on staging and trigger an error
  2. Load a figma file and recreate the component
  3. Load the figma component with an error
  4. See the color difference.

Here is a screenshot

Image

The image on the left is from staging, on the right is a brand new component built using VADS component library.

It looks like Figma is using vads-color-error whereas the code is using vads-color-error-dark.

Urgency

How urgent is this request? Please select the appropriate option below and/or provide details

  • This bug is blocking work currently in progress
  • This bug is affecting work currently in progress but we have a workaround
  • This bug is blocking work planned within the next few sprints
  • This bug is not blocking any work
  • Other

Details

@jeana-adhoc jeana-adhoc added bug Something isn't working platform-design-system-team labels Nov 14, 2024
@caw310 caw310 added the Figma label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants