Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

va-search-input: Resolve Stencil test warning about isTouched re-rendering #3539

Open
3 tasks
jamigibbs opened this issue Nov 20, 2024 · 0 comments · May be fixed by department-of-veterans-affairs/component-library#1414

Comments

@jamigibbs
Copy link
Contributor

jamigibbs commented Nov 20, 2024

Description

There is a Stencil test warning that we should resolve for va-search-input:

Image

A draft PR has been created that removes the @State decorator because it didn't seem like the correct use of @State Every time that variable is set, it's causing a full re-render of the component.

This solution or any alternate solution needs to be tested in vets-website. Specifically, we need to make sure the following issue is still fixed and there hasn't been any other regressions:

Tasks

  • resolve the Stencil warning for isTouched
  • verify that no regression were introduced in vets-website

Acceptance Criteria

  • the isTouched test warning is resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant