Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VACMS-19449]Situation updates static banner #32872

Closed
wants to merge 16 commits into from

Conversation

SnowboardTechie
Copy link
Contributor

@SnowboardTechie SnowboardTechie commented Nov 4, 2024

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
  • Yes, I'm removing, renaming or moving a folder

Did you change site-wide styles, platform utilities or other infrastructure?

Summary

  • Adds a situation updates banner component that when enabled, takes the div prepared by content-build and adds a banner for situation updates. Currently the banner is working with static data and disabled behind a feature flag. Future work will enable this banner on only the appropriate pages (locations with situation updates fetched from vets-api).
  • Sitewide team
  • This is kept behind the flipper flag banner_use_alternative_banners
  • Includes update to watch to setup with 12GB as 8 was not enough to complete builds

Related issue(s)

Testing done

  • This introduces no noticeable changes to users as long as the flipper remains disabled
  • When flipper is enabled, it updates the empty situation updates banner with the static data in the property config

Scre

Screenshot 2024-11-07 at 10 21 02 AM enshots

What areas of the site does it impact?

This is interacting with a header level feature so it has the potential for sitewide impact

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

@SnowboardTechie SnowboardTechie self-assigned this Nov 4, 2024
@va-vfs-bot va-vfs-bot temporarily deployed to master/VACMS-19449-situation-updates-v2/main November 4, 2024 19:28 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/VACMS-19449-situation-updates-v2/main November 4, 2024 21:07 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/VACMS-19449-situation-updates-v2/main November 5, 2024 16:05 Inactive
@SnowboardTechie SnowboardTechie force-pushed the VACMS-19449-situation-updates-v2 branch 3 times, most recently from 6e62f26 to 1c653f5 Compare November 5, 2024 17:03
@va-vfs-bot va-vfs-bot temporarily deployed to master/VACMS-19449-situation-updates-v2/main November 5, 2024 17:06 Inactive
@SnowboardTechie SnowboardTechie force-pushed the VACMS-19449-situation-updates-v2 branch 2 times, most recently from a918dd5 to 8b884d6 Compare November 5, 2024 18:00
@va-vfs-bot va-vfs-bot temporarily deployed to master/VACMS-19449-situation-updates-v2/main November 5, 2024 18:03 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/VACMS-19449-situation-updates-v2/main November 5, 2024 18:55 Inactive
@SnowboardTechie SnowboardTechie force-pushed the VACMS-19449-situation-updates-v2 branch from a980648 to 006bfef Compare November 5, 2024 20:21
@va-vfs-bot va-vfs-bot temporarily deployed to master/VACMS-19449-situation-updates-v2/main November 5, 2024 20:48 Inactive
@SnowboardTechie SnowboardTechie force-pushed the VACMS-19449-situation-updates-v2 branch 2 times, most recently from 6f0ba61 to e8d4fde Compare November 5, 2024 21:13
@va-vfs-bot va-vfs-bot temporarily deployed to master/VACMS-19449-situation-updates-v2/main November 5, 2024 21:46 Inactive
@SnowboardTechie SnowboardTechie force-pushed the VACMS-19449-situation-updates-v2 branch from e8d4fde to dc956b7 Compare November 5, 2024 22:02
@va-vfs-bot va-vfs-bot temporarily deployed to master/VACMS-19449-situation-updates-v2/main November 5, 2024 22:47 Inactive
@SnowboardTechie SnowboardTechie force-pushed the VACMS-19449-situation-updates-v2 branch from 0af17fd to ab5d089 Compare November 6, 2024 20:04
@va-vfs-bot va-vfs-bot temporarily deployed to master/VACMS-19449-situation-updates-v2/main November 6, 2024 20:37 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/VACMS-19449-situation-updates-v2/main November 6, 2024 21:41 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/VACMS-19449-situation-updates-v2/main November 7, 2024 14:55 Inactive
@SnowboardTechie SnowboardTechie force-pushed the VACMS-19449-situation-updates-v2 branch from 95e1bdf to 615be39 Compare November 7, 2024 15:59
@va-vfs-bot va-vfs-bot temporarily deployed to master/VACMS-19449-situation-updates-v2/main November 7, 2024 16:06 Inactive
@SnowboardTechie SnowboardTechie force-pushed the VACMS-19449-situation-updates-v2 branch from 615be39 to d059c72 Compare November 7, 2024 17:46
@va-vfs-bot va-vfs-bot temporarily deployed to master/VACMS-19449-situation-updates-v2/main November 7, 2024 18:21 Inactive
@SnowboardTechie SnowboardTechie marked this pull request as ready for review November 7, 2024 18:22
@SnowboardTechie SnowboardTechie requested a review from a team as a code owner November 7, 2024 18:22
eselkin
eselkin previously approved these changes Nov 7, 2024
Copy link
Contributor

@eselkin eselkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice use of the feature toggles in the tests.

@eselkin
Copy link
Contributor

eselkin commented Nov 7, 2024

Also, thanks for putting in the memory updates for watch. I thought I did, but seemed to have missed it somewhere in my changes.

randimays
randimays previously approved these changes Nov 7, 2024
Copy link
Contributor

@randimays randimays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SnowboardTechie SnowboardTechie dismissed stale reviews from eselkin and randimays via cda840d November 25, 2024 15:49
@SnowboardTechie SnowboardTechie force-pushed the VACMS-19449-situation-updates-v2 branch from 17d12e7 to cda840d Compare November 25, 2024 15:49
eselkin
eselkin previously approved these changes Nov 25, 2024
Copy link
Contributor

@eselkin eselkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
1 question about common practice/pattern

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants