-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependabot doesn't work with monorepos using pnpm #10758
Comments
FWIW we also see the same behaviour with |
Seeing the same with
Only package.json updates Tried |
The issue is mainly that we don't have a tree crawl for pnpm workspaces package.json files, like we do for some other files in dependabot's codebase. I've tried to propose a fix in #10806, but haven't heard back from the maintainers so far. |
Need to deploy #10806 PR |
I have created a sample repo to recreate this problem Note:
Current behaviour of dependabotScenario 1When
then PRs generated
Scenario 2When
then PRs generated
Scenario 3When
then PRs generated
As far as I know things are working as per the dependabot documentation. Could you please help me on recreating this issue.. Note: FYI @landongrindheim |
I suspect the key to reproducing might be having it update both directories/package.json files in a single PR. In our alveusgg repository we are combining directories and groups which seems to cause that? |
Is there an existing issue for this?
Package ecosystem
npm/pnpm
Package manager version
8.15.9
Language version
No response
Manifest location and content before the Dependabot update
package.json
pnpm-lock.yaml
pnpm-workspace.yaml
front/package.json
dependabot.yml content
https://github.com/boxwise/boxtribute/blob/master/.github/dependabot.yml
Updated dependency
No response
What you expected to see, versus what you actually saw
When explicitly listing
directories
, such asdirectories:
Dependabot generates updates for packages in the root package.json and in /front. However, it does not update the pnpm-lock.yaml in PRs for packages in the subfolder (for instance: boxwise/boxtribute#1599)
When only listing the 'root' directory (suggested by #4993), dependabot ignores the package.json within /front entirely.
Possibly related to #6346 (npm, not pnpm)
Native package manager behavior
No response
Images of the diff or a link to the PR, issue, or logs
boxwise/boxtribute#1599
Smallest manifest that reproduces the issue
No response
The text was updated successfully, but these errors were encountered: