Change DefaultRequirement in go_modules #11421
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… prerelease security updates.
|
Disregarding this PR, as this change does not conform semver. Looks like the root problem of the issue are incorrect versions constraints in the advisories itself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Fixes #11420 by changing DefaultRequirement to DefaultPrereleaseRequirement.
Anything you want to highlight for special attention from reviewers?
This seems like the most straightforward way to fix the problem where security updates incorrectly states that updates for versions v0.0.0 are not needed.
How will you know you've accomplished your goal?
Security updates should start succeed for go modules where vulnerable packages are versioned like v0.0.0-xxxx.
Checklist