Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support progress tracking for DownloadFile and UploadFile methods for service/dataset client #10

Open
98sean98 opened this issue Aug 31, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@98sean98
Copy link
Contributor

98sean98 commented Aug 31, 2023

Need some kind of progress tracking for the DownloadFile and UploadFile methods, otherwise there's no way for the consumer of these methods to know how many bytes have been transferred, and how many more bytes left to transfer.

Previous investigation:
Each of the cloud client's download object methods are kinda different. Perhaps aws s3 and gcp cloud storage are okay because they use io.Copy methods, but not azure. Azure actually has at least 2-3 methods that allows blob download, involving some kind of stream or buffer.
And for upload object methods, they're all different also.

If this feature can be implemented, it will be possible to render a progress bar for downstream consumers like deploifai/cli-go.

@98sean98 98sean98 added the enhancement New feature or request label Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant