Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SAMBAD-257] 질문 및 답변 패키지 내 코드 정리 #107

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

nahyeon99
Copy link
Member

✔️ PR 타입(하나 이상의 PR 타입을 선택해주세요)

  • 기능 추가
  • 버그 수정
  • 의존성, 환경 변수, 빌드 관련 코드 업데이트
  • 기타 사소한 수정

📝 개요

  • 질문, 답변, 모임질문, 모임답변 패키지 내 코드를 정리합니다.

💡 코드 리뷰 시 참고 사항

  • MeetingQuestion 클래스 내 if 문 분기 처리에서 예외가 발생하면 안될 것 같아서, 로그만 남기도록 수정했습니다.
	public void updateStatusToActive(LocalDateTime startTime) {
		if (this.status != NOT_STARTED) {
			LoggingUtils.error("다음 MeetingQuestion 의 활성화를 시도하였으나, 이미 시작되거나 종료된 질문입니다. meetingQuestionId : "
				+ id + " status : " + status.name());
		}
		this.startTime = startTime;
		this.expiredAt = startTime.plusSeconds(RESPONSE_TIME_LIMIT_SECONDS);
		this.status = ACTIVE;
	}

@nahyeon99 nahyeon99 self-assigned this Aug 16, 2024
Copy link

Unit Test Results

4 tests   4 ✔️  0s ⏱️
1 suites  0 💤
1 files    0

Results for commit 9a7157a.

Copy link
Collaborator

@kkjsw17 kkjsw17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했숨다~~ 👍

@nahyeon99 nahyeon99 merged commit 2b4a316 into develop Aug 16, 2024
2 checks passed
@nahyeon99 nahyeon99 deleted the feature/SAMBAD-257-clean_up_codes branch August 16, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants