New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add npm lockfile and packageManager info #40

Open

IlyaSemenov opened this issue Oct 14, 2024 · 0 comments

Contributor

IlyaSemenov commented Oct 14, 2024

The repo doesn't include lockfile, which is a bad practice. See:

https://docs.npmjs.com/cli/v10/configuring-npm/package-lock-json: "package-lock.json ... is intended to be committed into source repositories"
https://pnpm.io/git: "You should always commit the lockfile (pnpm-lock.yaml)."

Please commit the lockfile of whatever package manager you use. Also, please consider setting "packageManager" under package.json, see https://nodejs.org/api/packages.html#packagemanager.

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment