Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc update #3

Open
delitescere opened this issue May 29, 2018 · 0 comments
Open

Doc update #3

delitescere opened this issue May 29, 2018 · 0 comments

Comments

@delitescere
Copy link

Thank you for an awesome Zipkin tool for Elixir!

Using Phoenix, I had a little problem with the request_id not being found, it seems like now one has to explicitly use the Plug.RequestId in one's endpoint.ex (for example). Mine looks like this:

defmodule Ops.Web.Endpoint do
.
.
.
  # Zipkin (needs a `x-request-id` header, generated by the RequestId plug)
  plug Plug.RequestId
  plug PhxExRay.Tracing.Plug
.
.
.

Otherwise, it will be nil and all the subsequent code expects the value to be a binary.

I thought a small update in the readme might help others in the future.

Many thanks again,
Josh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant