Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when switching to dark mode on ARM64 #478

Closed
Frodojj opened this issue Sep 15, 2024 · 4 comments
Closed

Crash when switching to dark mode on ARM64 #478

Frodojj opened this issue Sep 15, 2024 · 4 comments

Comments

@Frodojj
Copy link

Frodojj commented Sep 15, 2024

Describe the crash
Crash with version 1.5.0 (arm64) downloaded from github and unzipped to downloads/explorerpp_arm64 folder.

To Reproduce
Steps to reproduce the crash:

  1. Go to Tools -> Options -> Appearance
  2. Change Theme to "System Default"
  3. Click Apply.

Version (please complete the following information):

  • Explorer++ version: 1.5.0.2483 dev (ARM64 build)
  • Build date: Sep 14 2024 00:10:58
  • OS: Windows 11

Additional context

@Frodojj
Copy link
Author

Frodojj commented Sep 15, 2024

Also occurred when setting theme to dark (I use dark mode on my computer). Updated title and posted new crash dump here:

Explorer++1.5.0.2483-15092024-145824.dmp

@Frodojj Frodojj changed the title Crash when changing theme to "system default" Crash when changing theme to dark mode or system default when windows in dark mode Sep 15, 2024
derceg added a commit that referenced this issue Sep 17, 2024
This is a potential fix for #478.
@derceg
Copy link
Owner

derceg commented Sep 17, 2024

Hi Frodojj, could you try the build available here and see if it fixes the crash?

@derceg derceg changed the title Crash when changing theme to dark mode or system default when windows in dark mode Crash when switching to dark mode on ARM64 Sep 19, 2024
@Frodojj
Copy link
Author

Frodojj commented Sep 20, 2024

That fixed it! Thank you.

@derceg
Copy link
Owner

derceg commented Sep 20, 2024

The fix I mentioned above has been merged in, so this issue has been closed. However, it now means that some scrollbars (e.g. the listview scrollbar) will appear light when dark mode is enabled on ARM64. I've opened a separate issue for that in #482.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants