Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: kaitai_struct_compiler upstream issues #15

Open
ManasviGoyal opened this issue Nov 22, 2023 · 2 comments
Open

fix: kaitai_struct_compiler upstream issues #15

ManasviGoyal opened this issue Nov 22, 2023 · 2 comments

Comments

@ManasviGoyal
Copy link
Collaborator

After merging kaitai_struct_compiler upstream, the kaitai-struct-compiler tool fails. With the upstream, we also need to reflect the new changes in CppCompiler.scala to AwkwardCompiler.scala since the later is a modified copy of the former.

@zonca
Copy link
Contributor

zonca commented Nov 27, 2023

After merging kaitai_struct_compiler upstream

what 2 branches are you merging?

the kaitai-struct-compiler tool fails.

what is the error? fails compiling which file?

With the upstream, we also need to reflect the new changes in CppCompiler.scala to AwkwardCompiler.scala since the later is a modified copy of the former.

it looks like we need to port the new commits affecting CppCompiler.scala to AwkwardCompiler.scala

@ManasviGoyal
Copy link
Collaborator Author

it looks like we need to port the new commits affecting CppCompiler.scala to AwkwardCompiler.scala

@zonca Yes exactly. The current branch ManasviGoyal/kaitai_awkward_target is not synced with the latest changes in kaitai-struct-compiler. Those changes need to be added.

When I tried making these changes, the generated .jar files were not able to parse the .ksy files to generate the source and header files.

@ManasviGoyal ManasviGoyal changed the title Fix kaitai_struct_compiler upstream issues fix: kaitai_struct_compiler upstream issues Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants