Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for import #17

Open
ManasviGoyal opened this issue Nov 22, 2023 · 0 comments
Open

feat: add support for import #17

ManasviGoyal opened this issue Nov 22, 2023 · 0 comments

Comments

@ManasviGoyal
Copy link
Collaborator

ManasviGoyal commented Nov 22, 2023

The current implementation does not support ksy files which have an import (e.g. midas.ksy). Also fix the multiple definition error for C functions.

@ManasviGoyal ManasviGoyal changed the title Add support for import feat: add support for import Dec 7, 2023
zonca added a commit to zonca/kaitai_struct_awkward_runtime that referenced this issue Jan 9, 2024
this is needed if we have multiple libraries in the same folder.
see
det-lab#24 (comment)

However when we implement `import`
det-lab#17
we will probably need to revisit again
ManasviGoyal pushed a commit that referenced this issue Jan 10, 2024
* test: improve makefile to compile with patterns

* test: unit test for fake.ksy

* test: generate list of libraries dynamically

* feat: only compile current cpp file

this is needed if we have multiple libraries in the same folder.
see
#24 (comment)

However when we implement `import`
#17
we will probably need to revisit again

* test: compare the actual array
zonca added a commit to zonca/kaitai_struct_awkward_runtime that referenced this issue Jan 10, 2024
this is needed if we have multiple libraries in the same folder.
see
det-lab#24 (comment)

However when we implement `import`
det-lab#17
we will probably need to revisit again
zonca added a commit to zonca/kaitai_struct_awkward_runtime that referenced this issue Jan 10, 2024
this is needed if we have multiple libraries in the same folder.
see
det-lab#24 (comment)

However when we implement `import`
det-lab#17
we will probably need to revisit again
ManasviGoyal pushed a commit that referenced this issue Jan 15, 2024
* test: improve makefile to compile with patterns

* test: unit test for fake.ksy

* test: generate list of libraries dynamically

* feat: only compile current cpp file

this is needed if we have multiple libraries in the same folder.
see
#24 (comment)

However when we implement `import`
#17
we will probably need to revisit again

* test: compare the actual array

* test index_option.ksy

* test: testing numpy.ksy

* test: test for pixie4e.ksy

* test: testing records.ksy

* test: test scdms.ksy

* test: test hello_world

Got data file from:
https://github.com/kaitai-io/kaitai_struct_tests

* test: testing scdms_v8.ksy

Also modified id in ksy to simplify scripting
Closes #27

* test: typo and formatting

* test: explain why shape is different

* test: remove WSL path that doesn't work
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant