Update profile to match CIS v1.1.0 #54
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-rock
reviewed
Oct 4, 2018
| @@ -0,0 +1,3 @@ | |||
| --- | |||
| lockfile_version: 1 | |||
There was a problem hiding this comment.
We should not include lock files
| @@ -237,6 +237,8 @@ | |||
| end | |||
| end | |||
|
|
|||
| # There is a mistake in the official CIS DIL documentaion 1.1.10-1.1.14 are | |||
There was a problem hiding this comment.
Should we remove them? I think there is no value in adding CIS misstakes in this profile. We could point this out in the README.
There was a problem hiding this comment.
Agreed, these can be left out. It's acknowledged as a bug by the CIS maintainers, however unresolved for about 8 months now.
|
@itoperatorguy Are you continuing on this PR? We're looking forward to the updated CiS checks |
fatbasstard
added a commit
to fatbasstard/cis-dil-benchmark
that referenced
this pull request
Oct 24, 2018
Processed the feedback given on original PR dev-sec#54
fatbasstard
added a commit
to fatbasstard/cis-dil-benchmark
that referenced
this pull request
Oct 24, 2018
Processed the feedback given on original PR dev-sec#54 Signed-off-by: Frank van Boven <[email protected]>
fatbasstard
added a commit
to fatbasstard/cis-dil-benchmark
that referenced
this pull request
Oct 24, 2018
Processed the feedback given on original PR dev-sec#54 Signed-off-by: Frank van Boven <[email protected]>
fatbasstard
added a commit
to fatbasstard/cis-dil-benchmark
that referenced
this pull request
Oct 24, 2018
Processed the feedback given on original PR dev-sec#54 Signed-off-by: Frank van Boven <[email protected]>
fatbasstard
added a commit
to fatbasstard/cis-dil-benchmark
that referenced
this pull request
Oct 24, 2018
Processed the feedback given on original PR dev-sec#54 Signed-off-by: Frank van Boven <[email protected]>
fatbasstard
added a commit
to fatbasstard/cis-dil-benchmark
that referenced
this pull request
Oct 24, 2018
Processed the feedback given on original PR dev-sec#54 Solved rebase issues Signed-off-by: Frank van Boven <[email protected]>
fatbasstard
added a commit
to fatbasstard/cis-dil-benchmark
that referenced
this pull request
Oct 24, 2018
Processed the feedback given on original PR dev-sec#54 Solved rebase issues Signed-off-by: Frank van Boven <[email protected]>
Dith3r
reviewed
Feb 5, 2019
| tag level: 1 | ||
|
|
||
| command("cat /etc/shadow | cut -d: -f1").stdout.split.each do |username| | ||
| describe command('date -d "`export LANG="en_US.UTF-8" ; chage --list root | grep "Last password" | cut -d: -f2`" +%s') do |
There was a problem hiding this comment.
instead of chage --list root it should use username also why u export us settings here?
| tag cis: 'distribution-independent-linux:5.4.5' | ||
| tag level: 2 | ||
|
|
||
| command("sudo find /etc/ -maxdepth 1 -name *bashrc*").stdout.split.each do |bashrc_file| |
There was a problem hiding this comment.
sudo should not be used in command invocation
There was a problem hiding this comment.
%w(bash.bashrc profile bashrc).each do |f|
next unless file("/etc/#{f}").file?
describe file("/etc/#{f}") do
its(:content) { should match /^TMOUT=([1-6]\d{2})|(\d{2})|{\d{1}}(\s*#.*)*$/ }
end
end
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I modified the controls where I could, so now the profile matches to the CIS v.1.1.0