Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styleguide is ignoring uppercase category names #185

Open
VaclovasV opened this issue Jun 29, 2016 · 1 comment
Open

Styleguide is ignoring uppercase category names #185

VaclovasV opened this issue Jun 29, 2016 · 1 comment
Assignees
Labels

Comments

@VaclovasV
Copy link
Contributor

Category name is uppercase, but filename is created with lowercase.
Styleguide should not ignore naming casing.

@VaclovasV VaclovasV added the bug label Jun 30, 2016
@miezis miezis self-assigned this Jul 15, 2016
@miezis
Copy link
Contributor

miezis commented Jul 23, 2016

I was able to reproduce this like so:

  1. Create new category, all letters lowercased (example: new category).
  2. Delete that category.
  3. Create new category with uppercase letters (example: New Category).

After these steps the situation is as described by @VaclovasV . It turns out that deleting categories did not delete files and when we were creating new category with same name (except letter cases) new file was not created.

I fixed it to delete category files, when deleting categories and also added category name checking to prevent duplicates in this commit: 742873e

Please review and test it out.

@miezis miezis assigned mantas-kunsmanas and unassigned miezis Jul 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants