Skip to content
This repository has been archived by the owner on May 24, 2022. It is now read-only.

User-provided GIF breaks group photo creation #46

Open
crcastle opened this issue Nov 2, 2020 · 0 comments
Open

User-provided GIF breaks group photo creation #46

crcastle opened this issue Nov 2, 2020 · 0 comments

Comments

@crcastle
Copy link
Contributor

crcastle commented Nov 2, 2020

When a user uploads a GIF instead of recording one, the group photo creation fails silently.

Steps to reproduce

Upload the GIF below to a deploy and also record a GIF the regular way. Then create a group photo with curl -X POST http://localhost:3001/createGroupPhoto. See error in log from that POST request. It will look something like this. Unfortunately I cannot figure out how to get a stack trace, but I believe the error comes from these lines of code -- specifically the composite() function call.

[Error: VipsImage: memory area too small --- should be 480000 bytes, you passed 360000
]

public_gifs_greeting-1604076477783

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant