Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Map overrides theme in VSC interactive display. #696

Open
deanm0000 opened this issue Oct 29, 2024 · 3 comments
Open

[BUG] Map overrides theme in VSC interactive display. #696

deanm0000 opened this issue Oct 29, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@deanm0000
Copy link

Context

When using lonboard in VSC jupyter interactive in dark mode, once I display a Map, the output for everything carries the theme of the Map of white background. Before running a map it looks like:
image

Resulting behaviour, error message or logs

After having run a map it looks like this:

image

Environment

Platform: Linux-5.15.153.1-microsoft-standard-WSL2-x86_64-with-glibc2.35
Python: 3.12.2 (main, Feb 25 2024, 16:35:05) [GCC 11.4.0]

  • Lonboard Version: '0.10.3'
    VSC: 1.93.1
    Chromium: 124.0.6367.243

Steps to reproduce the bug

Using VSC with dark theme. Make a map then all cells get the Map's style, at least for background and font.

@deanm0000 deanm0000 added the bug Something isn't working label Oct 29, 2024
@deanm0000 deanm0000 changed the title [BUG] A short yet descriptive title for the bug you're reporting [BUG] Map overrides theme in VSC interactive display. Oct 29, 2024
@kylebarron
Copy link
Member

I don't particularly understand CSS styling and what's happening here. But it's also quite difficult to provide CSS that works as expected in every environment, when Jupyter/JupyterLab/Colab/vscode etc are all implemented in different ways. Happy to accept a PR or maybe @vgeorge has time at some point to look into this. (but lower priority than some bugs in the last release like #675)

@eKerney
Copy link

eKerney commented Nov 20, 2024

Hello @kylebarron and @vgeorge I'm experiencing a similar issue with VSC and am wondering if there is any room to make a contribution on this? WSL2 ubuntu 22.04 - lonboard 0.10.3 - python 3.11.10

@kylebarron
Copy link
Member

A fix here would be greatly appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants