Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TODO: check that a team cannot update its own id #154

Open
kamicut opened this issue Mar 27, 2020 · 1 comment
Open

TODO: check that a team cannot update its own id #154

kamicut opened this issue Mar 27, 2020 · 1 comment
Labels
Category: API Type: Bug Something isn't working
Milestone
Refactor & Tech Debt

Comments

@kamicut
Copy link
Member

kamicut commented Mar 27, 2020

In the team model, a team calls update with the request body coming into the API. We should write a test to see what happens when the request body includes a different id. Does this overwrite the team id?
@kamicut kamicut added Type: Question Further information is requested Category: API labels Mar 27, 2020
@kamicut kamicut self-assigned this Mar 27, 2020
@guidorice
Copy link

We also noticed this from the swagger ui.

@kamicut kamicut removed their assignment May 20, 2020
@vgeorge vgeorge added Type: Bug Something isn't working and removed Type: Question Further information is requested Status: Review Needed Category: Teams Priority: High labels Oct 17, 2022
@vgeorge vgeorge added this to the Refactor & Tech Debt milestone Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Category: API Type: Bug Something isn't working
Projects
None yet
Milestone
Refactor & Tech Debt
Development

No branches or pull requests
3 participants
@vgeorge @kamicut @guidorice