Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make titiler-xarray a dependency for titiler-cmr? #35

Open
maxrjones opened this issue Oct 23, 2024 · 1 comment
Open

Make titiler-xarray a dependency for titiler-cmr? #35

maxrjones opened this issue Oct 23, 2024 · 1 comment

Comments

@maxrjones
Copy link
Member

I'm wondering if it would be possible to depend on titiler-xarray for titiler-cmr rather than having a separate XarrayReader in this library? The benefit of this would be reducing code duplication. For example, the code being discussed in #34 exists separately in both libraries. The reader module in titiler-cmr has very few differences from the reader module in titiler-xarray, with the exception of having an additional MultiFilesBandsReader and a different approach to caching datasets.

@vincentsarago
Copy link
Member

@maxrjones We will do this once we've done developmentseed/titiler-xarray#68

for now titiler-xarray is not publish on pypi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants