-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aws private api deployment #725
Closed
Jeandsmith
wants to merge
13
commits into
developmentseed:main
from
Jeandsmith:aws-private-api-deployment
Closed
Aws private api deployment #725
Jeandsmith
wants to merge
13
commits into
developmentseed:main
from
Jeandsmith:aws-private-api-deployment
+136
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
that's interesting! from my understanding, the lambda is not directly within the VPC but only the API gateway? |
Yup. Is not directly attach thought it can be. The API simply will be proxying the request back to the lambda |
Name was conflicting with constructs package
This looks very useful! Curious if there is any accompanying documentation planned for how to use this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I am changing
Added an example for a deployment of a AWS private rest-api based on public-sector use developers.
How you can test it
No tests, simply deploy after setting the
vpc_endpoint_id
config value.