New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

makeMove with fedback about success or fail #33

Open

dkwach opened this issue Nov 10, 2022 · 0 comments · May be fixed by #35

dkwach commented Nov 10, 2022

In current version makeMove methods doesn't return anything.

It could be useful to propagate information from game.move to the caller if move was accepted or rejected.
Use cases:

info for user that move was rejected on some status bar or other widget
chess engine development when engine is providing incorrect move

Instead return bool, raising some exception will be also good (However I would recommend to keep chess.move consistency )

dkwach linked a pull request

that will close this issue

add move with uci param and return move result #35

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment